Conversation
When `jp query --no-edit` runs without an explicit query, the request is synthesized (either the conversation's trailing message is re-sent, or a default "continue" is used) instead of coming from the user. This synthesized text was previously treated the same as a plain inline query and never echoed, so the user had no way to see what was actually sent to the LLM. The query's origin is now tracked with a three-way `QuerySource` enum (`Editor`, `Inline`, `Synthesized`) instead of a plain boolean. `should_echo_request` echoes whenever the source isn't `Inline`, so editor-composed, replayed, and now synthesized queries are all shown to the user before the turn runs. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
jp query --no-editruns without an explicit query, the request is synthesized (either the conversation's trailing message is re-sent, or a default "continue" is used) instead of coming from the user. This synthesized text was previously treated the same as a plain inline query and never echoed, so the user had no way to see what was actually sent to the LLM.The query's origin is now tracked with a three-way
QuerySourceenum (Editor,Inline,Synthesized) instead of a plain boolean.should_echo_requestechoes whenever the source isn'tInline, so editor-composed, replayed, and now synthesized queries are all shown to the user before the turn runs.