fix(cli): Defer shading of gap after tool call in reasoning - #882
Merged
Conversation
The blank line after tool chrome that resumes a shaded reasoning region was shaded immediately, based only on whether the next chunk was reasoning. When that chunk turned out to be whitespace-only (or already truncated), it rendered nothing, so the gap actually landed between the tool chrome and the following message or tool call, but still carried the reasoning background. This produced a shaded blank line outside the reasoning region. The gap is now deferred the same way a reasoning block defers its own trailing separator: it is only resolved, and only then shaded or left plain, once the content that actually follows is known. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blank line after tool chrome that resumes a shaded reasoning region was shaded immediately, based only on whether the next chunk was reasoning. When that chunk turned out to be whitespace-only (or already truncated), it rendered nothing, so the gap actually landed between the tool chrome and the following message or tool call, but still carried the reasoning background. This produced a shaded blank line outside the reasoning region.
The gap is now deferred the same way a reasoning block defers its own trailing separator: it is only resolved, and only then shaded or left plain, once the content that actually follows is known.