Conversation
Pressing enter at the `pr-triage` recipe's confirmation prompt now runs the triage query, same as answering `p`. Previously an empty answer fell through to the catch-all `*` case and silently did nothing, which made the default (just pressing enter) behave differently from the labeled "proceed" option. The catch-all is narrowed to `n|N` so any other input still aborts the recipe instead of being silently accepted. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing enter at the
pr-triagerecipe's confirmation prompt now runs the triage query, same as answeringp. Previously an empty answer fell through to the catch-all*case and silently did nothing, which made the default (just pressing enter) behave differently from the labeled "proceed" option.The catch-all is narrowed to
n|Nso any other input still aborts the recipe instead of being silently accepted.