chore(tools): Report searched-line count on no diff matches - #894
Merged
Conversation
`grep_diff` now includes the number of lines searched in its no-match message, e.g. "No matches for pattern 'foo' in the diff output (9 lines searched)." Previously a zero-match result gave no indication of how much of the diff was actually scanned, making it hard to tell a narrow search window from a broken filter. The line count is computed once from the search bounds and reused for both the no-match message and the "[Showing X/Y lines...]" note, so the two always agree on what "the diff" means when bounds are set. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grep_diffnow includes the number of lines searched in its no-match message, e.g. "No matches for pattern 'foo' in the diff output (9 lines searched)." Previously a zero-match result gave no indication of how much of the diff was actually scanned, making it hard to tell a narrow search window from a broken filter.The line count is computed once from the search bounds and reused for both the no-match message and the "[Showing X/Y lines...]" note, so the two always agree on what "the diff" means when bounds are set.