fix(term): Measure truncation prefixes as whole strings - #905
Merged
Conversation
JeanMertz
force-pushed
the
background-fill-mode-fixes
branch
from
July 30, 2026 10:45
bafc6e5 to
06a13fe
Compare
`truncate_to_width` summed per-cluster display widths to find where to cut a string before appending an ellipsis. That sum is wrong for sequences that ligate or combine into something narrower than their parts: Arabic Lam-Alef spans two clusters that sum to two columns but render as one, and similar sequences elsewhere could overspend the budget and cut earlier than necessary. The fix measures each candidate prefix as a whole string instead of summing its clusters, so ligating sequences are accounted for at their true rendered width. This also fixes a zero-width edge case: a zero-column input (e.g. a lone ZWJ) now survives a zero-column budget unchanged, since it already fits, rather than being dropped for the ellipsis. Only input wider than the budget is truncated. Signed-off-by: Jean Mertz <git@jeanmertz.com>
JeanMertz
force-pushed
the
background-fill-mode-fixes
branch
from
July 30, 2026 11:51
59be602 to
50a9061
Compare
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
truncate_to_widthsummed per-cluster display widths to find where tocut a string before appending an ellipsis. That sum is wrong for
sequences that ligate or combine into something narrower than their
parts: Arabic Lam-Alef spans two clusters that sum to two columns but
render as one, and similar sequences elsewhere could overspend the
budget and cut earlier than necessary. The fix measures each candidate
prefix as a whole string instead of summing its clusters, so ligating
sequences are accounted for at their true rendered width.
This also fixes a zero-width edge case: a zero-column input (e.g. a
lone ZWJ) now survives a zero-column budget unchanged, since it
already fits, rather than being dropped for the ellipsis. Only input
wider than the budget is truncated.