Conversation
`jp conversation print --style` applied its preset by rewriting the shared render config before building each turn's renderer, which forced every turn to rebuild from the *current* per-turn config instead of the config that turn actually ran with. In a conversation where the model changed mid-way, `--style full` (and other presets) mislabeled every turn with whichever model was configured when the preset was applied, hiding the fact that earlier turns ran on a different model. Style presets are now expressed as a `StyleOverlay` (reasoning display, tool call visibility, tool style) that the `TurnRenderer` re-applies on top of each turn's own rebuilt config, rather than mutating the config used to select that turn's identity. `--style` therefore only changes presentation, and `--current-config` remains the explicit way to render every turn under the workspace's current config, including its model. Closes: #869 Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jp conversation print --styleapplied its preset by rewriting the shared render config before building each turn's renderer, which forced every turn to rebuild from the current per-turn config instead of the config that turn actually ran with. In a conversation where the model changed mid-way,--style full(and other presets) mislabeled every turn with whichever model was configured when the preset was applied, hiding the fact that earlier turns ran on a different model.Style presets are now expressed as a
StyleOverlay(reasoning display, tool call visibility, tool style) that theTurnRendererre-applies on top of each turn's own rebuilt config, rather than mutating the config used to select that turn's identity.--styletherefore only changes presentation, and--current-configremains the explicit way to render every turn under the workspace's current config, including its model.Closes: #869