feat(cli): Add . and +live conversation target keywords - #937
Merged
Conversation
The session's active conversation is what `jp query`, `jp c print`, and
most other conversation commands resolve to when given no target, but it
had no name in the target grammar. Reaching it explicitly meant looking
up its ID by hand:
jp c grep --id jp-c17761673600 branch
`.` (long form `active`) names it, so the same search becomes:
jp c grep -i. branch
`+l` (long form `+live`) names the whole live corpus, filling the other
hole in the grammar: `+pinned` and `+session` could each say "all of
this partition", but nothing said "all of them". Bare `+` is left
unbound on purpose, reserved for a future keyword spanning both the
live and archive partitions, so `+l` and a later `+all` can mean
different things.
`latest` is renamed to `recent`, and its short form `l` to `r`. English
carries the distinction the pair needs: `recent` is what was last used,
`newest` is what was last created. `latest` and `newest` both read as
"most recent", leaving the activated-versus-created difference to the
help text alone. The rename also frees `l`, so `+l` no longer sits
beside an unrelated `l`. RFD 087's workspace targeting table, which
reuses these keywords, is updated to match.
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The session's active conversation is what
jp query,jp c print, and most other conversation commands resolve to when given no target, but it had no name in the target grammar. Reaching it explicitly meant looking up its ID by hand:.(long formactive) names it, so the same search becomes:+l(long form+live) names the whole live corpus, filling the other hole in the grammar:+pinnedand+sessioncould each say "all of this partition", but nothing said "all of them". Bare+is left unbound on purpose, reserved for a future keyword spanning both the live and archive partitions, so+land a later+allcan mean different things.latestis renamed torecent, and its short formltor. English carries the distinction the pair needs:recentis what was last used,newestis what was last created.latestandnewestboth read as "most recent", leaving the activated-versus-created difference to the help text alone. The rename also freesl, so+lno longer sits beside an unrelatedl. RFD 087's workspace targeting table, which reuses these keywords, is updated to match.