Compose pr-loop review with bundled pr-review - #8
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ed48b8a35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dceoy
left a comment
There was a problem hiding this comment.
Reviewed exact head 2ed48b8a357dd26336dd68b0f5754d1c6617041e. I found one additional actionable race-safety issue beyond the existing standalone-mode finding. CI is green on this head.
69a05aa to
1cc8b21
Compare
dceoy
left a comment
There was a problem hiding this comment.
Reviewed frozen head 1cc8b219e2f304b90214f088ef634f071295d09b. I found one actionable feedback-reconciliation issue in the new historical-review design. CI/CD is green on this head.
dceoy
left a comment
There was a problem hiding this comment.
Reviewed exact head d28965d59c8a4caf5ef0c1584fca7f2fe84749ac. I found one actionable standalone-compatibility regression. CI/CD is green on this head.
dceoy
left a comment
There was a problem hiding this comment.
Reviewed exact head 78333e8a8b63f28845b6ad578f2de7948bff3e26. I found one actionable fail-closed orchestration regression. CI/CD is green on this head.
dceoy
left a comment
There was a problem hiding this comment.
Reviewed exact head 9fb3d42263dbc8eeb0361f916ae98c1d4ac52f1a.
No new actionable findings were found in this review pass. The earlier review findings are resolved, and CI/CD is green on this head.
Summary
pr-reviewand its review references fromdceoy/ai-coding-agent-skillspr-loopexecutepr-reviewas its review phase in the same top-level agent context instead of duplicating review policypr-loopreviews frozen-head and commit-bound so historical feedback remains unambiguous when the live head advancespr-reviewfallback from the source skill: when commit-bound publication is unavailable, re-check the live head immediately before posting and publish only if it still equals the frozen snapshotpr-loop; after each composed review returns, re-check the PR head and immediately re-runpr-reviewfor a newer head before feedback analysis or fixespr-reviewthrough.agents/skillsand keep standalone use availablereviewerrole to support both discovery and independent validation tasksDesign
pr-reviewis procedural composition, not nested delegation. The top-levelpr-loopagent remains the single writer; review discovery and validation subagents stay direct fresh read-only terminal leaves.When composed by
pr-loop,pr-reviewowns one frozen-head review from discovery through verified COMMENT publication and requires explicit commit-bound publication to the supplied exact target. If the live head advances, the historical review may still be posted unambiguously;pr-loopthen skips feedback analysis/fixes for that old head and invokespr-reviewagain for the new head.Standalone
pr-reviewprefers the same commit-bound publication but does not require it. If the runtime can post only to the current head, it performs duplicate suppression, re-checks that the live head still equals the frozen reviewed SHA as the final pre-publication gate, and posts only when they match; otherwise it restarts from the new live head.Feedback dispositions, fixes, replies, and resolutions remain exact-head gated, and historical feedback retains source-head provenance for revalidation against the current reviewed head.
Validation
pr-loopreview still requires commit-bound publication to the supplied exact targetpr-reviewretains a safe current-head fallback when historical commit targeting is unavailablepr-loopre-checks the live head immediately after composed review publication and loops back before feedback analysis when it changedskills/pr-loop/SKILL.md