Skip to content

Compose pr-loop review with bundled pr-review - #8

Merged
dceoy merged 7 commits into
mainfrom
refactor/compose-pr-review
Sep 5, 2026
Merged

Compose pr-loop review with bundled pr-review#8
dceoy merged 7 commits into
mainfrom
refactor/compose-pr-review

Conversation

@dceoy

@dceoy dceoy commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • bundle pr-review and its review references from dceoy/ai-coding-agent-skills
  • make pr-loop execute pr-review as its review phase in the same top-level agent context instead of duplicating review policy
  • keep composed pr-loop reviews frozen-head and commit-bound so historical feedback remains unambiguous when the live head advances
  • retain the standalone pr-review fallback from the source skill: when commit-bound publication is unavailable, re-check the live head immediately before posting and publish only if it still equals the frozen snapshot
  • move live-head change detection across review rounds to pr-loop; after each composed review returns, re-check the PR head and immediately re-run pr-review for a newer head before feedback analysis or fixes
  • expose pr-review through .agents/skills and keep standalone use available
  • adapt the Codex reviewer role to support both discovery and independent validation tasks

Design

pr-review is procedural composition, not nested delegation. The top-level pr-loop agent remains the single writer; review discovery and validation subagents stay direct fresh read-only terminal leaves.

When composed by pr-loop, pr-review owns one frozen-head review from discovery through verified COMMENT publication and requires explicit commit-bound publication to the supplied exact target. If the live head advances, the historical review may still be posted unambiguously; pr-loop then skips feedback analysis/fixes for that old head and invokes pr-review again for the new head.

Standalone pr-review prefers the same commit-bound publication but does not require it. If the runtime can post only to the current head, it performs duplicate suppression, re-checks that the live head still equals the frozen reviewed SHA as the final pre-publication gate, and posts only when they match; otherwise it restarts from the new live head.

Feedback dispositions, fixes, replies, and resolutions remain exact-head gated, and historical feedback retains source-head provenance for revalidation against the current reviewed head.

Validation

  • parsed the updated reviewer TOML successfully
  • verified local relative links between the composed skills and review references
  • verified composed pr-loop review still requires commit-bound publication to the supplied exact target
  • verified standalone pr-review retains a safe current-head fallback when historical commit targeting is unavailable
  • verified pr-loop re-checks the live head immediately after composed review publication and loops back before feedback analysis when it changed
  • verified historical feedback source-head provenance is preserved for feedback analysis
  • retained the reduction of duplicated review policy in skills/pr-loop/SKILL.md

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ed48b8a35

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread skills/pr-review/SKILL.md Outdated

@dceoy dceoy left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head 2ed48b8a357dd26336dd68b0f5754d1c6617041e. I found one additional actionable race-safety issue beyond the existing standalone-mode finding. CI is green on this head.

Comment thread skills/pr-review/SKILL.md Outdated
@dceoy
dceoy force-pushed the refactor/compose-pr-review branch from 69a05aa to 1cc8b21 Compare September 5, 2026 14:46

@dceoy dceoy left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed frozen head 1cc8b219e2f304b90214f088ef634f071295d09b. I found one actionable feedback-reconciliation issue in the new historical-review design. CI/CD is green on this head.

Comment thread skills/pr-loop/SKILL.md Outdated

@dceoy dceoy left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head d28965d59c8a4caf5ef0c1584fca7f2fe84749ac. I found one actionable standalone-compatibility regression. CI/CD is green on this head.

Comment thread skills/pr-review/SKILL.md Outdated

@dceoy dceoy left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head 78333e8a8b63f28845b6ad578f2de7948bff3e26. I found one actionable fail-closed orchestration regression. CI/CD is green on this head.

Comment thread skills/pr-loop/SKILL.md

@dceoy dceoy left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head 9fb3d42263dbc8eeb0361f916ae98c1d4ac52f1a.

No new actionable findings were found in this review pass. The earlier review findings are resolved, and CI/CD is green on this head.

@dceoy
dceoy merged commit efa658b into main Sep 5, 2026
7 checks passed
@dceoy
dceoy deleted the refactor/compose-pr-review branch September 5, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant