Make jison a dev dependency and ship less files.#94
Closed
realityking wants to merge 1 commit into
Closed
Conversation
Author
|
This would also help a licensing situation for Apiary, see apiaryio/fury-adapter-swagger#168. @dchester ping |
|
@dchester Is there anything blocking this? Could this get merged? |
Author
15fea8c to
ae919f9
Compare
|
Can we please get a merge and publish of this @dchester? |
Owner
|
I like this one -- I'll take a closer look and aim to get it merged. |
|
@dchester Any news? 😄 |
Owner
|
This is merged in spirit, with 7fbf022 which is published as version 1.0.2. That makes jison a dev dependency, and then we point the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
jisonbecomes a dev-depency. It's not used at runtime anyway.Jison pulls in quite a few dependencies so this slims down the footprint of this package quite a bit.
Not exposing the grammar on the parser makes the code a bit smaller, should be especially beneficial in the browser.