Closed
Conversation
Replace static SITE_ID_CURRENT_SITE / DOMAIN_CURRENT_SITE / BLOG_ID_CURRENT_SITE constants with dynamic HTTP_HOST-based network detection in sunrise.php, sunrise-events.php, and sunrise-wordcamp.php. This makes sunrise work in any environment without relying on wp-config.php constants being set first. Also add 0-aaa-constants.php mu-plugin that provides fallback constant definitions for environments where wp-config.php hasn't defined them yet. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
DDEV provides full control over wp-config.php via disable_settings_management, solving the bootstrap ordering issues that prevented wp-env from working. - config.yaml: MariaDB 10.11, PHP 8.5, nginx-fpm, all .test domains - nginx/multisite.conf: Subdirectory and Events network rewrite rules - wp-config-ddev.php: Full wp-config template with all constants pre-defined - setup.sh: Idempotent post-start hook (WP core, seed DB, test suite) - web-build/Dockerfile: SVN for Composer packages and WP test suite Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- phpunit-bootstrap.php: Detect DDEV environment for correct paths - unit-tests.yml: Replace MySQL service + setup-php with DDEV - .gitignore: Add DDEV generated file patterns - composer.json: Add test:ddev convenience script Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Composer needs setup-php for proper wpackagist authentication and platform config. DDEV provides the MariaDB database and PHP runtime for running tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
These plugins/themes have been removed from wordpress.org and are no longer available via wpackagist: - camptix-payfast-gateway - supportflow - tagregator - p2 theme Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The DDEV db user lacks CREATE DATABASE privileges. Use root/root (DDEV default) for the install-wp-tests.sh script. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The get_redirect_url() function now uses HTTP_HOST instead of a hardcoded domain. Tests need to set this value. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- wp-config-ddev.php: Use __DIR__ instead of dirname(__FILE__) - 0-aaa-constants.php: Start doc comment with capital letter Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
Owner
Author
|
Closing in favour of wp-env and the existing docker containers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key changes
Test plan
Generated with Claude Code