ci(textlint): fail on errors instead of only annotating (#8800) [skip ci] - #8800
Merged
Merged
Conversation
… [skip buildkite] ## Short Summary (TL;DR) The docs-check textlint step reported errors as annotations but still passed, so terminology errors merged unnoticed. This makes it fail, and fixes the six errors that had slipped in. ## The Issue - No issue filed `tsuyoshicho/action-textlint` defaults to `fail_level: none`, so reviewdog annotates and exits 0. Run 33621739955 was green on main with six errors that `make textlint` reports locally. ## How This PR Solves The Issue Sets `fail_level: error`, matching the `fail_on_error: true` linkspector already uses. `filter_mode` stays at its default `added`, so only lines a PR adds are checked. ## Manual Testing Instructions `make textlint` reports no problems. Reintroducing `tradeoff` in a docs file fails it again. ## Automated Testing Overview The docs-check workflow is the test. ## Release/Deployment Notes CI and docs text only, no user-facing change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
rfay
approved these changes
Sep 3, 2026
rfay
left a comment
rfay
left a comment
Member
There was a problem hiding this comment.
My goodness, finally! Thank you!
rfay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Summary (TL;DR)
The docs-check textlint step reported errors as annotations but still passed, so terminology errors merged unnoticed. This makes it fail, and fixes the six errors that had slipped in.
The Issue
tsuyoshicho/action-textlintdefaults tofail_level: none, so reviewdog annotates and exits 0. Run 33621739955 was green on main with six errors thatmake textlintreports locally.How This PR Solves The Issue
Sets
fail_level: error, matching thefail_on_error: truelinkspector already uses.filter_modestays at its defaultadded, so only lines a PR adds are checked.Manual Testing Instructions
make textlintreports no problems. Reintroducingtradeoffin a docs file fails it again.Automated Testing Overview
The docs-check workflow is the test.
Release/Deployment Notes
CI and docs text only, no user-facing change.