Skip to content

Fix BH2O-36 energy units, change metrics#691

Merged
ElliottKasoar merged 3 commits into
ddmms:mainfrom
kuryla:bh2o-36
Jul 13, 2026
Merged

Fix BH2O-36 energy units, change metrics#691
ElliottKasoar merged 3 commits into
ddmms:mainfrom
kuryla:bh2o-36

Conversation

@kuryla

@kuryla kuryla commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Pre-review checklist for PR author

PR author must check the checkboxes below when creating the PR.

Summary

Errors were nonsensical because the reference energies were in Hartree and predicted energies in eV. Changed reference energies to eV in calc script. Changed all energies to kcal/mol in analysis and modified thresholds to 0.7 kcal/mol (MAE of wB97M-V vs CCSD) and 20 kcal/mol.

Linked issue

Resolves #

Testing

@ElliottKasoar ElliottKasoar added the bug Something isn't working label Jul 13, 2026
@ElliottKasoar

Copy link
Copy Markdown
Collaborator

Thanks, @kuryla!

I think some stray files got added along with your changes. There's a lowercase copy (bh2o-36) for both the calculation and analysis.

For future reference, it can be helpful to use the -u (--update) flag with git add, which only adds changes in files that are already tracked.

@kuryla

kuryla commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator Author

I see, I removed those irrelevant commits now

@ElliottKasoar ElliottKasoar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ElliottKasoar ElliottKasoar merged commit b481c9c into ddmms:main Jul 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants