Skip to content

Validate command/config flags when exporting HTML table#11642

Merged
ChillerDragon merged 1 commit intoddnet:masterfrom
Robyt3:Scripts-Settings-Commands-Flag-Validation
Jan 17, 2026
Merged

Validate command/config flags when exporting HTML table#11642
ChillerDragon merged 1 commit intoddnet:masterfrom
Robyt3:Scripts-Settings-Commands-Flag-Validation

Conversation

@Robyt3
Copy link
Copy Markdown
Member

@Robyt3 Robyt3 commented Jan 17, 2026

Prevent new config/command flags from being added without also handling them in the HTML table export script.

Checklist

  • Tested the change: no difference in output
  • Provided screenshots if it is a visual change
  • Tested in combination with possibly related configuration options: adding an unknown command flag (Reduce conditional compilation of debug dummies #11546)
  • Written a unit test (especially base/) or added coverage to integration test
  • Considered possible null pointers and out of bounds array indexing
  • Changed no physics that affect existing maps
  • Tested the change with ASan+UBSan or valgrind's memcheck (optional)
  • I didn't use generative AI to generate more than single-line completions

Prevent new config/command flags from being added without also handling them in the HTML table export script.


def parse_flags(flags_str, name):
flags = flags_str.split(" | ")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally would split on "|" and then strip it. To not make this check dependent on the clang formatter. But eh whatever. That is basically one of the key benefits of using a formatter to not have to write flexible code parsers anymore. I just find it annoying when I get a failing CI and when trying to investigate the issue I realize it was actually another test that failed (formatting) which caused it.

@ChillerDragon ChillerDragon added this pull request to the merge queue Jan 17, 2026
Merged via the queue into ddnet:master with commit 24579a6 Jan 17, 2026
21 checks passed
@Robyt3 Robyt3 deleted the Scripts-Settings-Commands-Flag-Validation branch February 10, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants