Validate command/config flags when exporting HTML table#11642
Merged
ChillerDragon merged 1 commit intoddnet:masterfrom Jan 17, 2026
Merged
Validate command/config flags when exporting HTML table#11642ChillerDragon merged 1 commit intoddnet:masterfrom
ChillerDragon merged 1 commit intoddnet:masterfrom
Conversation
Prevent new config/command flags from being added without also handling them in the HTML table export script.
8 tasks
ChillerDragon
approved these changes
Jan 17, 2026
|
|
||
|
|
||
| def parse_flags(flags_str, name): | ||
| flags = flags_str.split(" | ") |
Member
There was a problem hiding this comment.
I personally would split on "|" and then strip it. To not make this check dependent on the clang formatter. But eh whatever. That is basically one of the key benefits of using a formatter to not have to write flexible code parsers anymore. I just find it annoying when I get a failing CI and when trying to investigate the issue I realize it was actually another test that failed (formatting) which caused it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent new config/command flags from being added without also handling them in the HTML table export script.
Checklist