Lasttrick really final#35
Merged
Merged
Conversation
sorenhein
pushed a commit
that referenced
this pull request
May 18, 2026
…_eleven refactor(movegen): encapsulate move generation via SolverContext (Task 06)
sorenhein
pushed a commit
that referenced
this pull request
May 18, 2026
- Remove duplicate gtest include from trick_three_bug.cpp - Place Doxygen file header at top of file - Clarify Task 09 code quality checks (warnings observed vs explicitly checked) - Clarify Task 10 validation status (warnings observed vs explicitly checked) - Correct Task 02 googletest dependency analysis (@googletest, not @com_google_googletest) All builds pass, tests pass (1/1 solve_board, 28/28 full suite).
sorenhein
pushed a commit
that referenced
this pull request
May 18, 2026
Code changes (trick_three_bug.cpp): - Assert SolveBoard return value explicitly (RETURN_NO_FAULT) - Fix assertion to use ASSERT_EQ with correct types - Fix test fixture class to use Allman braces - Fix protected access specifier indentation (4 spaces) - Add trailing return type to dds_max helper function Documentation changes: - Task 08: Fix googletest dependency examples (@googletest, not @com_google_googletest) - Task 09: Update checklist to reflect actual checks performed - Task 10: Update quality metrics to match actual validation All builds pass, tests pass (1/1 solve_board, 28/28 full suite).
sorenhein
pushed a commit
that referenced
this pull request
May 18, 2026
…_board Stage 9: Modernize library/tests/solve_board to C++ coding standards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.