Skip to content

Align meson library naming and make tests optional - #184

Merged
mnottoli merged 2 commits into
ddsolvation:mainfrom
robin-dahl:meson-test-option
Sep 2, 2026
Merged

Align meson library naming and make tests optional#184
mnottoli merged 2 commits into
ddsolvation:mainfrom
robin-dahl:meson-test-option

Conversation

@robin-dahl

Copy link
Copy Markdown
Contributor

Summary

This PR improves ddX's meson integration for downstream projects such as tblite and xTB.

The optional test suite is needed because ddX's tests are otherwise added unconditionally to the parent project's default build graph. In particular, the symlink-based ddx_driver_testing source currently fails to compile on Windows when ddX is consumed through tblite.

The default standalone behavior remains unchanged, and the complete test suite passes with tests enabled.

@mnottoli

mnottoli commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

I was not entirely satisfied by skipping the failing test on Windows rather than fixing it, so I removed the symlink.
Since we already have a python wrapper run_test.py, we can just point it to the right executable (ddx_driver) rather than making the symlink.

Since we don't have the symlink anymore, the meson_test_wrapper.in and the workaround to create bash scripts are no longer needed.

Can you test if everything works also when ddX is a subproject?

If you are satisfied with the modifications, I will merge the PR and tag the new ddX version.

@robin-dahl

Copy link
Copy Markdown
Contributor Author

@mnottoli I just tested it, and it seems like everything is working. Thank you!

@mnottoli
mnottoli merged commit 7626442 into ddsolvation:main Sep 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants