Align meson library naming and make tests optional - #184
Merged
Conversation
mnottoli
force-pushed
the
meson-test-option
branch
from
September 2, 2026 09:46
3cfcd0a to
581354a
Compare
Collaborator
|
I was not entirely satisfied by skipping the failing test on Windows rather than fixing it, so I removed the symlink. Since we don't have the symlink anymore, the Can you test if everything works also when ddX is a subproject? If you are satisfied with the modifications, I will merge the PR and tag the new ddX version. |
Contributor
Author
|
@mnottoli I just tested it, and it seems like everything is working. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves ddX's
mesonintegration for downstream projects such as tblite and xTB.mesonlibrary name withCMakeby producinglibddxinstead oflibddX, addressing ddX library name differs between meson and CMake build #179.-Dddx:tests=false.The optional test suite is needed because ddX's tests are otherwise added unconditionally to the parent project's default build graph. In particular, the symlink-based
ddx_driver_testingsource currently fails to compile on Windows when ddX is consumed through tblite.The default standalone behavior remains unchanged, and the complete test suite passes with tests enabled.