Fix/time converter gmt label - #58
Conversation
|
@codex please review this PR and verify that GMT inputs keep their original label in the response, while timezone normalization and conversions remain correct. Please avoid overanalyzing unrelated code. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 451b755b4e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ) | ||
| first_line_prefix = ( | ||
| f"{source_datetime:%H:%M} {source_timezone} " | ||
| f"{source_datetime:%H:%M} {display_timezone} " |
There was a problem hiding this comment.
Now that the reply text varies based on display_timezone, the edit-dedup signature in handle_time_message still records only hour/minute and the normalized timezone_label. When an already-processed message is edited from 10:00 UTC+3 to 10:00 GMT+3 (or back), those signature fields remain identical, so is_message_signature_unchanged returns early and the bot reply keeps the old label instead of reflecting the GMT input.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Good catch. I’ll include display_timezone in the edit signature and add coverage for edits between UTC+3 and GMT+3.
| display_timezone_label = ( | ||
| f"{input_timezone_prefix}{label_sign}{abs(offset_hours)}" | ||
| ) |
There was a problem hiding this comment.
For accepted zero-padded offset inputs such as 10:00 GMT+03, match.group("timezone") contains the user's GMT+03 label, but rebuilding the display label from the parsed integer changes the response to GMT+3. Since this change is specifically preserving the GMT label while keeping timezone_label normalized for conversion, use the matched timezone text for display_timezone_label instead of reconstructing it from offset_hours.
Useful? React with 👍 / 👎.
1 participant
Preserve the original GMT label in time converter responses.
GMT+3when the user enteredGMT+3