Fix/parse time with parenthesized timezone in text - #66
Conversation
|
@codex Please review this PR strictly within the scope of the time parsing fix. sample text: Verify that timezone abbreviations wrapped in parentheses inside longer text messages are parsed correctly, including 10:00 (UTC) in the provided Binance Alpha announcement. The 250 AEON tokens expression is expected to remain ignored under the current crypto eligibility rules and is outside the scope of this PR. Please also verify that support for parentheses does not introduce false matches or regressions in the existing time formats. No nice-to-have suggestions – only issues directly related to this feature. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd7920e1e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Fix time parsing for timezone abbreviations wrapped in parentheses inside longer text messages.
The time converter now recognizes formats such as 10:00 (UTC) without changing the existing behavior for already supported time formats.
Added a regression test using the original Binance Alpha announcement to verify that the embedded time is detected correctly.