Skip to content

Fix/parse time with parenthesized timezone in text - #66

Merged
deKibi merged 4 commits into
mainfrom
fix/parse-time-with-parenthesized-timezone-in-text
Jul 30, 2026
Merged

Fix/parse time with parenthesized timezone in text#66
deKibi merged 4 commits into
mainfrom
fix/parse-time-with-parenthesized-timezone-in-text

Conversation

@deKibi

@deKibi deKibi commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Fix time parsing for timezone abbreviations wrapped in parentheses inside longer text messages.

The time converter now recognizes formats such as 10:00 (UTC) without changing the existing behavior for already supported time formats.

Added a regression test using the original Binance Alpha announcement to verify that the embedded time is detected correctly.

@deKibi deKibi self-assigned this Jul 30, 2026
@deKibi

deKibi commented Jul 30, 2026

Copy link
Copy Markdown
Owner Author

@codex Please review this PR strictly within the scope of the time parsing fix.

sample text:

Binance Alpha is the first platform to feature AEON (AEON), with Alpha debut and trading starting on July 27, 2026, at 10:00 (UTC). 

Users with at least 245 Binance Alpha Points can claim an airdrop of 250 AEON tokens on a first-come, first-served basis. If the reward pool is not fully distributed, the score threshold will automatically decrease by 5 points every 5 minutes.

Please note that claiming the airdrop will consume 15 Binance Alpha Points. Users must confirm their claim on the Alpha Events page within 24 hours; otherwise, it will be deemed that users have given up claiming the airdrop.

Verify that timezone abbreviations wrapped in parentheses inside longer text messages are parsed correctly, including 10:00 (UTC) in the provided Binance Alpha announcement.

The 250 AEON tokens expression is expected to remain ignored under the current crypto eligibility rules and is outside the scope of this PR.

Please also verify that support for parentheses does not introduce false matches or regressions in the existing time formats. No nice-to-have suggestions – only issues directly related to this feature.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd7920e1e9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread time_converter/utc_time_parser.py Outdated
@deKibi
deKibi merged commit 2e8700e into main Jul 30, 2026
5 checks passed
@deKibi
deKibi deleted the fix/parse-time-with-parenthesized-timezone-in-text branch July 30, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant