Skip to content

Do not report failure if project cannot be configured.#245

Merged
masterleinad merged 1 commit into
dealii:masterfrom
marcfehling:relax-ci
Apr 30, 2026
Merged

Do not report failure if project cannot be configured.#245
masterleinad merged 1 commit into
dealii:masterfrom
marcfehling:relax-ci

Conversation

@marcfehling
Copy link
Copy Markdown
Member

Our CI script strictly reports failure if a project cannot be configured. This patch relaxes this requirement by skipping projects that cannot be configured by cmake, e.g., because they miss dependencies or require a more recent version of deal.II.

This is motivated by the fact that #240 requires PETSc to be configured with complex support, which our docker image does not provide. Further, new contributions often require the latest deal.II installation, which causes failures in the CI because we also check on older deal.II versions. This requires contributors to make the code backwards-compatible and adds extra work for them just to make the CI pass -- I do not see any necessity for it and would rather relax the requirements.

This patch also adds a short summary at the end. This is the output on my machine. I do not have preCISE nor XBraid installed, thus I could not configure coupled_laplace_problem and parallel_in_time. Magneto_Active_Polymers_Book will always be skipped because the folder does not contain a CMakeLists.txt.

Summary:
  advection_reaction_estimator                                           passed.
  cdr                                                                    passed.
  CeresFE                                                                passed.
  coupled_laplace_problem                                                skipped.
  Crystal_Growth_Phase_Field_Model                                       passed.
  Distributed_LDG_Method                                                 passed.
  Distributed_Moving_Laser_Heating                                       passed.
  ElastoplasticTorsion                                                   passed.
  goal_oriented_elastoplasticity                                         passed.
  Heat_Eqn_Parallel                                                      passed.
  information_based_mesh_refinement                                      passed.
  Linear_Elastic_Active_Skeletal_Muscle_Model                            passed.
  Magneto_Active_Polymers_Book                                           skipped.
  Maxwell-Eigenvalue-hp-Refinement                                       passed.
  MCMC-Laplace                                                           passed.
  MultipointFluxMixedFiniteElementMethods                                passed.
  NavierStokes_TRBDF2_DG                                                 passed.
  nonlinear-heat_transfer_with_AD_NOX                                    passed.
  Nonlinear_PoroViscoelasticity                                          passed.
  parallel_in_time                                                       skipped.
  Phase_field_fracture_model_in_3D                                       passed.
  Quasi_static_Finite_strain_Compressible_Elasticity                     passed.
  Quasi_static_Finite_strain_Quasi_incompressible_ViscoElasticity        passed.
  Swift-Hohenberg-Solver                                                 passed.
  time_dependent_navier_stokes                                           passed.
  TravelingWaves                                                         passed.
  two_phase_flow                                                         passed.

@marcfehling marcfehling added the github_actions Pull requests that update GitHub Actions code label Apr 30, 2026
Copy link
Copy Markdown
Member

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. This is a good idea.

@masterleinad
Copy link
Copy Markdown
Member

This will also allow specifying a higher minimal deal.II version. Maybe not a bad thing.

@masterleinad masterleinad merged commit fbe2282 into dealii:master Apr 30, 2026
5 checks passed
@marcfehling marcfehling deleted the relax-ci branch April 30, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants