Do not report failure if project cannot be configured.#245
Merged
Conversation
Report a summary.
blaisb
approved these changes
Apr 30, 2026
Member
blaisb
left a comment
There was a problem hiding this comment.
Very nice. This is a good idea.
Member
|
This will also allow specifying a higher minimal deal.II version. Maybe not a bad thing. |
masterleinad
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our CI script strictly reports failure if a project cannot be configured. This patch relaxes this requirement by skipping projects that cannot be configured by cmake, e.g., because they miss dependencies or require a more recent version of deal.II.
This is motivated by the fact that #240 requires PETSc to be configured with complex support, which our docker image does not provide. Further, new contributions often require the latest deal.II installation, which causes failures in the CI because we also check on older deal.II versions. This requires contributors to make the code backwards-compatible and adds extra work for them just to make the CI pass -- I do not see any necessity for it and would rather relax the requirements.
This patch also adds a short summary at the end. This is the output on my machine. I do not have preCISE nor XBraid installed, thus I could not configure
coupled_laplace_problemandparallel_in_time.Magneto_Active_Polymers_Bookwill always be skipped because the folder does not contain aCMakeLists.txt.