Skip to content

test: scrub brand name from whisper segmentation fixture - #162

Merged
debpalash merged 1 commit into
mainfrom
chore/scrub-brand-fixture
May 30, 2026
Merged

test: scrub brand name from whisper segmentation fixture#162
debpalash merged 1 commit into
mainfrom
chore/scrub-brand-fixture

Conversation

@debpalash

@debpalash debpalash commented May 30, 2026

Copy link
Copy Markdown
Owner

The whisper_screenshot transcription fixture (tests/fixtures/whisper_screenshot.json) and its segmentation test referenced a real product/brand name in the sample transcript. Swapped it for the neutral placeholder Acme (fixture text + chunks + the expected-segment assertions in test_segmentation.py), keeping the consolidation behavior the test validates identical. git grep confirms no trace remains in any tracked file; test_segmentation.py stays green (26 passed).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Updated mock data in segmentation tests to use different sample text values. No functional changes to test logic or assertions.

Review Change Stack

The whisper_screenshot transcription fixture + its segmentation test
referenced a real product/brand name. Swap it for the neutral placeholder
'Acme' (fixture text + chunks + the expected-segment assertions), keeping
the test's consolidation behavior identical.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 30, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 306a366a-fed6-4254-8a94-b25afbd92e13

📥 Commits

Reviewing files that changed from the base of the PR and between 4af5d69 and 8333f3a.

⛔ Files ignored due to path filters (1)
  • tests/fixtures/whisper_screenshot.json is excluded by !tests/fixtures/**
📒 Files selected for processing (1)
  • tests/test_segmentation.py

📝 Walkthrough

Walkthrough

A single test fixture update: mock whisper chunk text in the fragmented-whisper segmentation test was changed from "Yupc" and "Yupcha" to "Acme" across two fragments, with no changes to test assertions or control flow.

Changes

Test Mock Data Update

Layer / File(s) Summary
Whisper chunk mock data
tests/test_segmentation.py
Mock whisper chunk text strings updated from "So we built Yupc" to "So we built Acme" and from "Try Yupcha if" to "Try Acme if" in the test_no_mid_word_splits_on_fragmented_whisper test, with no changes to assertions or logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the key changes and testing, but the PR description provided is missing required template sections like Type, Testing details, and Checklist items. Complete the PR description by filling in all required template sections, including Type (Tests checkbox), detailed Testing approach, and Checklist verification items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: replacing a brand name with a neutral placeholder in a test fixture.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/scrub-brand-fixture

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented May 30, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes a real product/brand name from a Whisper transcription fixture and its associated segmentation test, replacing all occurrences with the neutral placeholder Acme. No logic, timestamps, or test coverage changes.

  • tests/fixtures/whisper_screenshot.json: three references to "Yupc"/"Yupcha" in the top-level text string and two chunk entries are replaced with "Acme"; all timestamps remain identical.
  • tests/test_segmentation.py: two expected-segment assertion tuples updated from the old strings to "Acme", keeping the mid-word-fragment consolidation behavior under test exactly the same.

Confidence Score: 5/5

Safe to merge — only test fixture strings and matching assertion literals are touched.

Both files change only string literals used as expected values; the fixture structure, timestamps, and all test logic are identical before and after. A repo-wide grep confirms no remnant of the old strings in any tracked file.

No files require special attention.

Important Files Changed

Filename Overview
tests/fixtures/whisper_screenshot.json Three brand-name occurrences ("Yupc"/"Yupcha") replaced with neutral placeholder "Acme"; fixture structure and timestamps unchanged.
tests/test_segmentation.py Two assertion tuples updated to match the renamed fixture strings; test logic and coverage are identical to before.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[whisper_screenshot.json fixture] -->|text + chunks| B[test_segmentation.py\nTestSegmentTranscript]
    B -->|segment_transcript call| C{assert consolidation\n1 < len segs < 8}
    C -->|pass| D[26 tests green]

    subgraph Brand Scrub
        E["'Yupc' / 'Yupcha'"] -->|replaced with| F["'Acme'"]
    end

    F --> A
Loading

Reviews (1): Last reviewed commit: "test: scrub brand name from whisper segm..." | Re-trigger Greptile

@debpalash
debpalash merged commit 0fbc65f into main May 30, 2026
15 checks passed
@debpalash
debpalash deleted the chore/scrub-brand-fixture branch June 12, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant