fix(#346): never return an empty filtered stack — first-frame fallback + hiddenFrames annotation - #348
Merged
Merged
Conversation
…k + hiddenFrames annotation
An all-internal pause (e.g. a goroutine parked in Go runtime frames) used to
yield an empty get_stack_trace result under Go/.NET policies — a dead end for
agents: no frameId to anchor scopes/evaluate, and includeInternals
undiscoverable. Policies also disagreed (JS kept the first frame, Java kept
everything, Go/.NET returned []).
Central resolution in SessionManagerData so every adapter gets the same
guarantee, with the response saying what was hidden:
- getStackTraceDetailed returns {frames, totalFrameCount, hiddenFrameCount,
allFramesInternal}; if a policy filters every frame, the top unfiltered
frame is kept. getStackTrace remains as a thin array wrapper, so internal
callers (auto-continue, locals extraction) inherit the guarantee.
- get_stack_trace tool response adds hiddenFrames + a note explaining
includeInternals when any frames were hidden; tool description and
docs/tool-reference.md updated.
- Per-policy filters untouched.
Fixes #346
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An all-internal pause (e.g. a goroutine parked in Go runtime frames) used to
yield an empty get_stack_trace result under Go/.NET policies — a dead end for
agents: no frameId to anchor scopes/evaluate, and includeInternals
undiscoverable. Policies also disagreed (JS kept the first frame, Java kept
everything, Go/.NET returned []).
Central resolution in SessionManagerData so every adapter gets the same
guarantee, with the response saying what was hidden:
allFramesInternal}; if a policy filters every frame, the top unfiltered
frame is kept. getStackTrace remains as a thin array wrapper, so internal
callers (auto-continue, locals extraction) inherit the guarantee.
includeInternals when any frames were hidden; tool description and
docs/tool-reference.md updated.
Fixes #346
Co-Authored-By: Claude Fable 5 noreply@anthropic.com