This repository was archived by the owner on Feb 27, 2023. It is now read-only.
fix: rpc race condition#702
Merged
Merged
Conversation
Contributor
Test this pull request
|
leanmendoza
approved these changes
Nov 15, 2022
kuruk-mm
pushed a commit
that referenced
this pull request
Nov 16, 2022
This reverts commit e9c92ad.
kuruk-mm
pushed a commit
that referenced
this pull request
Nov 16, 2022
kuruk-mm
added a commit
that referenced
this pull request
Nov 16, 2022
kuruk-mm
added a commit
that referenced
this pull request
Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes race condition in which transports are created and connected before instantiating the first port.
Also exposes the rendererPort to the scenes, to be used with new RPC modules
Also fixes linter issues.
The idea behind exposing a port to a scene is to continue moving forward in the direction of kernel doing as few things as possible. Enabling the possibility to act as proxy to send requests directly to the renderer. To do so, it would need to create a port per scene to send all the messages of the scene using that port. @pbosio @leanmendoza this can be a later change