Skip to content
This repository was archived by the owner on Feb 27, 2023. It is now read-only.

Revert "fix: rpc race condition"#712

Merged
kuruk-mm merged 1 commit into
mainfrom
revert-702-test-race-conditions
Nov 16, 2022
Merged

Revert "fix: rpc race condition"#712
kuruk-mm merged 1 commit into
mainfrom
revert-702-test-race-conditions

Conversation

@menduz
Copy link
Copy Markdown
Member

@menduz menduz commented Nov 15, 2022

Reverts #702

It seems like the released version of the renderer doesn't respond the binary messages over web sockets but the editor version does.

@menduz menduz requested a review from a team as a code owner November 15, 2022 20:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 15, 2022

Test this pull request

@kuruk-mm kuruk-mm force-pushed the revert-702-test-race-conditions branch from 42c16ce to 8f91fb8 Compare November 16, 2022 12:36
@kuruk-mm kuruk-mm enabled auto-merge (squash) November 16, 2022 12:36
@kuruk-mm
Copy link
Copy Markdown
Member

Force push to verify the commit

@kuruk-mm kuruk-mm disabled auto-merge November 16, 2022 12:37
@kuruk-mm kuruk-mm merged commit 06ff955 into main Nov 16, 2022
@kuruk-mm kuruk-mm deleted the revert-702-test-race-conditions branch November 16, 2022 12:46
kuruk-mm added a commit that referenced this pull request Nov 16, 2022
kuruk-mm added a commit that referenced this pull request Nov 16, 2022
…tion (#702)" (#712)" (#714)

* Revert "Revert "fix: rpc race condition (#702)" (#712)"

This reverts commit 06ff955.

* increment major
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants