feat: Add optional from in chat#270
Merged
Merged
Conversation
Test this pull request
|
kuruk-mm
reviewed
Jun 4, 2025
kevinszuchet
requested review from
fcolarich and
kuruk-mm
and removed request for
pravusjif
June 4, 2025 13:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new optional from field in the Chat message defined in our protobuf protocol.
🎯 Purpose
As part of the Communities chat implementation, we’re introducing an intermediate actor — the Comms Message SFU — responsible for receiving messages from the client, validating the sender, resolving the list of community members, and then forwarding the message to the correct recipients.
Because the message is re-broadcasted by the SFU (instead of the original sender), the receiving clients would otherwise see the SFU as the sender. To preserve the identity of the original author, we’re adding the from field, allowing clients to properly render the original sender in the chat UI.
🧱 Changes
This change is backward-compatible, as the new field is optional and won’t affect existing message flows outside the Communities context.