feat: add communities voice chat proto objects#283
Merged
juanmahidalgo merged 7 commits intoJul 28, 2025
Merged
Conversation
Test this pull request on NPM or Yarn
|
|
|
||
| message StartCommunityVoiceChatResponse { | ||
| message Ok { | ||
| string voice_chat_id = 1; |
There was a problem hiding this comment.
We can either:
- Have different rooms, one per voice chat initiated
- Have a single room, with the same id o room name for each community voice chat, whose id is related to the community.
If we go with the second option, the voice_chat_id should not be needed.
The same happens with the JoinCommunityVoiceChatResponse type.
| } | ||
|
|
||
| // Getting active community voice chats for user's communities | ||
| message GetCommunityVoiceChatsResponse { |
There was a problem hiding this comment.
If we're able to get if a community has an active voice chat when requesting them via the HTTP endpoint, this should not be needed, what do you think about removing it?
* feat: add ended status to CommunityVoiceChatUpdate * feat: add CommunityVoiceChatStatus * feat: choose another name
juanmahidalgo
deleted the
feat/social-service-v2-proto-communities-voice-chat
branch
July 28, 2025 08:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.