fix: confirm MANA send once per hash to prevent infinite update loop#684
Open
eordano wants to merge 1 commit into
Open
fix: confirm MANA send once per hash to prevent infinite update loop#684eordano wants to merge 1 commit into
eordano wants to merge 1 commit into
Conversation
The confirm effect re-fired whenever its onSuccess prop changed identity (the parent re-renders on every tx-store notification and passes an inline arrow), each run re-notifying the store: an infinite update loop that crashed the wallets page with React #185 (white page) after a send. Guard the effect with a confirmedHash ref, mirroring the existing recordedHash pattern. Adds a unit regression (onSuccess identity churn) and an integration spec against the real store that reproduces the crash on the unguarded code. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/two-factor-authentication |
Coverage Report for CI Build 29686099002Coverage increased (+0.001%) to 96.059%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Send MANA flow re-triggered its confirmation effect on every render, causing an infinite update loop that crashed the account wallets page. This confirms a send only once per transaction hash.
Adds unit and integration coverage for SendManaContent.