chore: modernize the husky pre-commit hook#686
Open
eordano wants to merge 1 commit into
Open
Conversation
Drop the deprecated husky v9 shim line (removed in v10, where it breaks the hook) and fix the precommit script's --config path, which pointed at a nonexistent .husky/pre-commit.js. Husky and the lint-staged pre-commit hook stay in place. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Closed
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/two-factor-authentication |
Coverage Report for CI Build 29686661277Coverage remained the same at 96.058%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Husky is not deprecated, but this repo's pre-commit hook used the legacy v9 boilerplate (
. "$(dirname "$0")/_/husky.sh"), which husky v10 removes — so the hook would break on the next husky major. Theprecommitscript also pointed--configat a nonexistent.husky/pre-commit.js.This migrates the hook to the modern husky format (the hook file runs the command directly) and fixes the precommit script, keeping husky and the lint-staged pre-commit check in place.
Supersedes #685, which removed husky entirely and would have dropped the pre-commit hook.