Skip to content

Conversation

@timmilesdw
Copy link
Contributor

Fixed --insecure flag for mirror push

Updated the github.com/deckhouse/deckhouse/pkg/registry dependency to the fixed version that properly handles the --insecure flag.

Problem

The --insecure flag was being ignored when pushing to HTTP registries, causing TLS errors even when users explicitly requested insecure connections.

Root Cause

The registry client dependency had a bug that unconditionally reset opts.Insecure = false, preventing HTTP connections to insecure registries.

Solution

Updated the dependency to include the fix from deckhouse/deckhouse#17554

Testing

The bug only affects real hostnames and public IPs. It doesn't affect localhost, 127.0.0.1, or private IPs because go-containerregistry automatically uses HTTP for these addresses.

To test with localhost, add a custom hostname to /etc/hosts:

echo "127.0.0.1 myregistry.test" | sudo tee -a /etc/hosts
./bin/d8 mirror push ./bundle myregistry.test:5000/deckhouse --insecure

@timmilesdw timmilesdw requested a review from ldmonster as a code owner January 20, 2026 10:22
@timmilesdw timmilesdw self-assigned this Jan 20, 2026
@timmilesdw timmilesdw added the bug Something isn't working label Jan 20, 2026
Signed-off-by: Timur Tuktamyshev <timur.tuktamyshev@flant.com>
@ldmonster ldmonster merged commit ead0a0a into main Jan 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants