[deckhouse] fix: registry client #17554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the
--insecureflag in the registry client. The flag was being unconditionally reset tofalseinNewClientWithOptions, preventing HTTP connections to insecure registries.Changes:
opts.Insecure = falseinNewClientWithOptionsinsecurefield to theClientstruct to preserve the flag across operationsnameOptions()helper method that returnsname.Insecureoption when the client is configured for HTTPname.ParseReference()calls (7 locations) to usenameOptions()for proper HTTP/HTTPS scheme handlingWhy do we need it, and what problem does it solve?
Users need to connect to container registries over HTTP (without TLS) in development environments, air-gapped installations, and when working with local registries. The
--insecureflag was being ignored due to a bug that unconditionally reset it tofalse, causing all registry connections to attempt HTTPS regardless of user configuration. This made it impossible to use the mirror push/pull commands with insecure registries.Checklist
Changelog entries