Skip to content

[deckhouse-cli] Run go mod tidy to fix the v0.30.22 build - #461

Merged
Glitchy-Sheep merged 1 commit into
release-0.30from
fix/cve-x-image-tidy
Aug 28, 2026
Merged

[deckhouse-cli] Run go mod tidy to fix the v0.30.22 build#461
Glitchy-Sheep merged 1 commit into
release-0.30from
fix/cve-x-image-tidy

Conversation

@Fkuloff

@Fkuloff Fkuloff commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Problem

v0.30.22 does not build. Every go build target fails with:

go: updates to go.mod needed; to update it:
	go mod tidy

The x/image bump in #460 was applied with go mod edit because go mod tidy could not run without access to the flant.internal replacement of github.com/hashicorp/vault. That missed the transitive cascade: golang.org/x/text v0.41.0 requires golang.org/x/tools v0.48.0 and golang.org/x/mod v0.38.0, while go.mod still pinned v0.47.0 and v0.37.0, so the recorded requirements no longer cover the build list.

Fallout: the v0.30.22 Release workflow failed, so the tag has no published binaries, and deckhouse release-1.73 — which pins d8CliVersion v0.30.22 — fails both Build FE (builds d8 from the tag) and Go Generate (downloads the release binary, 404).

Fix

go mod tidy output, nothing hand-written:

  • golang.org/x/mod v0.37.0 -> v0.38.0
  • golang.org/x/tools v0.47.0 -> v0.48.0
  • go.sum drops the orphaned golang.org/x/image v0.39.0 and golang.org/x/text v0.40.0 entries

No package versions change beyond what x/text v0.41.0 already required, and the go directive stays at 1.25.6.

Tests

  • go mod tidy runs clean with the private module resolved
  • go build ./cmd/d8 with the release tag set (clionly dfrunsecurity dfrunnetwork dfrunmount dfssh containers_image_openpgp) succeeds; on v0.30.22 the same command fails with the error above

This needs a v0.30.23 release so deckhouse release-1.73 can move its pin off the broken tag.

Signed-off-by: Artem Kuleshov <artem.kuleshov@flant.com>
@Fkuloff
Fkuloff requested a review from Glitchy-Sheep August 28, 2026 13:31
@Fkuloff Fkuloff self-assigned this Aug 28, 2026
@Fkuloff
Fkuloff marked this pull request as ready for review August 28, 2026 13:36
@Fkuloff
Fkuloff requested a review from ldmonster as a code owner August 28, 2026 13:36
@Glitchy-Sheep
Glitchy-Sheep merged commit 14e7824 into release-0.30 Aug 28, 2026
5 checks passed
@Glitchy-Sheep
Glitchy-Sheep deleted the fix/cve-x-image-tidy branch August 28, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants