Skip to content

[deckhouse] bump addon-operator to fix module install with conversion webhooks#21365

Merged
ldmonster merged 6 commits into
release-1.76from
fix/helm3lib-take-ownership
Jul 17, 2026
Merged

[deckhouse] bump addon-operator to fix module install with conversion webhooks#21365
ldmonster merged 6 commits into
release-1.76from
fix/helm3lib-take-ownership

Conversation

@Fkuloff

@Fkuloff Fkuloff commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Backport to release-1.76 of the addon-operator fix for installing modules whose Helm chart references an object that already exists in the cluster — for example a conversion webhook the module applies through its hooks before the release is deployed. Such a module previously failed on install with an ownership error; with the fix Helm adopts the existing object and the module reaches the Ready state.

Why do we need it, and what problem does it solve?

A module that ships an object created outside its Helm release — most commonly a ConversionWebhook applied ahead of the release — could not install: Helm refused to take ownership of the pre-existing object, so the module stayed in an error state. This change backports the upstream addon-operator fix so those modules install cleanly on release-1.76.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: deckhouse
type: fix
summary: Bump addon-operator to fix module install with conversion webhooks
impact_level: low

@Fkuloff
[deckhouse] bump addon-operator to fix module install with conversion…
4c71bce 
… webhooks

Signed-off-by: Artem Kuleshov <artem.kuleshov@flant.com>
@github-actions github-actions Bot added type/dependencies Pull requests that update a dependency file area/core Pull requests that update core modules security/gitleaks/success Gitleaks PR diff scan passed labels Jul 15, 2026
@Fkuloff
Fkuloff requested a review from ldmonster July 15, 2026 10:23
@Fkuloff Fkuloff added this to the v1.76.5 milestone Jul 15, 2026
@github-actions github-actions Bot added the security/rootless/failed Default-user (rootless) validation failed label Jul 15, 2026
@Fkuloff Fkuloff added the e2e/run/gcp Run e2e tests in Google Cloud label Jul 15, 2026
@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🔴 e2e: GCP for deckhouse:fix/helm3lib-take-ownership failed in 8m32s.

E2e for gcp WithoutNAT;containerd;1.34 was failed. Use:

/e2e/abort gcp;WithoutNAT;containerd;1.34 29417755725 29417755725-1-con-1-34 /sys/deckhouse-oss/install:pr21365 - for abort failed cluster

Workflow details (1 job failed)

🔴 e2e: GCP, Containerd, Kubernetes 1.34 failed in 7m26s.

@github-actions github-actions Bot removed the e2e/run/gcp Run e2e tests in Google Cloud label Jul 15, 2026
@deckhouse-BOaTswain deckhouse-BOaTswain added the e2e/cluster/failed Pull request contains failed e2e cluster label Jul 15, 2026
@Fkuloff Fkuloff added the e2e/run/gcp Run e2e tests in Google Cloud label Jul 15, 2026
@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🔴 e2e: GCP for deckhouse:fix/helm3lib-take-ownership failed in 8m32s.

E2e for gcp WithoutNAT;containerd;1.34 was failed. Use:

/e2e/abort gcp;WithoutNAT;containerd;1.34 29418737812 29418737812-1-con-1-34 /sys/deckhouse-oss/install:pr21365 - for abort failed cluster

Workflow details (1 job failed)

🔴 e2e: GCP, Containerd, Kubernetes 1.34 failed in 7m27s.

@github-actions github-actions Bot removed the e2e/run/gcp Run e2e tests in Google Cloud label Jul 15, 2026
@Fkuloff Fkuloff added e2e/run/dvp Run e2e tests in Dvp and removed e2e/cluster/failed Pull request contains failed e2e cluster labels Jul 15, 2026
@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🟢 e2e: DVP for deckhouse:fix/helm3lib-take-ownership succeeded in 31m28s.

Workflow details

DVP-WithoutNAT-Containerd-1.34 - Connection string: ssh -J e2e-user@185.11.73.171 debian@10.12.1.69

🟢 e2e: DVP, Containerd, Kubernetes 1.34 succeeded in 30m16s.

@github-actions github-actions Bot removed the e2e/run/dvp Run e2e tests in Dvp label Jul 15, 2026
@Fkuloff Fkuloff added the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Jul 15, 2026
@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🟢 e2e: Yandex.Cloud for deckhouse:fix/helm3lib-take-ownership succeeded in 41m54s.

Workflow details

Yandex.Cloud-WithoutNAT-Containerd-1.34 - Connection string: ssh cloud-user@51.250.3.153

🟢 e2e: Yandex.Cloud, Containerd, Kubernetes 1.34 succeeded in 40m44s.

@github-actions github-actions Bot removed the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Jul 15, 2026
@Fkuloff Fkuloff added the e2e/run/dvp Run e2e tests in Dvp label Jul 15, 2026
@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🟢 e2e: DVP for deckhouse:fix/helm3lib-take-ownership succeeded in 31m22s.

Workflow details

DVP-WithoutNAT-Containerd-1.34 - Connection string: ssh -J e2e-user@185.11.73.171 debian@10.12.0.155

🟢 e2e: DVP, Containerd, Kubernetes 1.34 succeeded in 30m10s.

@github-actions github-actions Bot removed the e2e/run/dvp Run e2e tests in Dvp label Jul 15, 2026
@Fkuloff Fkuloff added the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Jul 15, 2026
@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🟢 e2e: Yandex.Cloud for deckhouse:fix/helm3lib-take-ownership succeeded in 40m26s.

Workflow details

Yandex.Cloud-WithoutNAT-Containerd-1.34 - Connection string: ssh cloud-user@89.169.142.93

🟢 e2e: Yandex.Cloud, Containerd, Kubernetes 1.34 succeeded in 39m13s.

@github-actions github-actions Bot removed the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Jul 15, 2026
@Fkuloff
Fkuloff marked this pull request as ready for review July 15, 2026 22:58
@Fkuloff
Fkuloff force-pushed the fix/helm3lib-take-ownership branch from d870905 to 9008c53 Compare July 17, 2026 07:23
@Fkuloff
[deckhouse] 1
853fc25 
Signed-off-by: Artem Kuleshov <artem.kuleshov@flant.com>
@Fkuloff
Fkuloff requested a review from 090809 as a code owner July 17, 2026 07:26
@github-actions github-actions Bot added the area/cluster-and-infrastructure Pull requests that update infra modules label Jul 17, 2026
@ldmonster
fix kruise
752a82d 
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
@github-actions github-actions Bot added the area/network Pull requests that update cni and network modules label Jul 17, 2026
@Fkuloff Fkuloff added the e2e/run/dvp Run e2e tests in Dvp label Jul 17, 2026
@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🔴 e2e: DVP for deckhouse:fix/helm3lib-take-ownership failed in 1h46m53s.

E2e for dvp WithoutNAT;containerd;1.34 was failed. Use:
ssh -i ~/.ssh/e2e-id-rsa debian@10.12.4.112 - connect for debugging;

/e2e/abort dvp;WithoutNAT;containerd;1.34 29569259696 29569259696-1-con-1-34 /sys/deckhouse-oss/install:pr21365 debian@10.12.4.112 - for abort failed cluster

Workflow details (1 job failed)

DVP-WithoutNAT-Containerd-1.34 - Connection string: ssh -J e2e-user@185.11.73.171 debian@10.12.4.112

🔴 e2e: DVP, Containerd, Kubernetes 1.34 failed in 1h22m40s.

@github-actions github-actions Bot removed the e2e/run/dvp Run e2e tests in Dvp label Jul 17, 2026
@Fkuloff
[deckhouse] deploy capi-controller-manager secret and rbac in pre-ins…
446cdf6 
…tall wave

Signed-off-by: Artem Kuleshov <artem.kuleshov@flant.com>
@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🔴 e2e: DVP for deckhouse:fix/helm3lib-take-ownership failed in 56m46s.

E2e for dvp WithoutNAT;containerd;1.34 was failed. Use:
ssh -i ~/.ssh/e2e-id-rsa debian@10.12.4.139 - connect for debugging;

/e2e/abort dvp;WithoutNAT;containerd;1.34 29572233068 29572233068-1-con-1-34 /sys/deckhouse-oss/install:pr21365 debian@10.12.4.139 - for abort failed cluster

Workflow details (1 job failed)

DVP-WithoutNAT-Containerd-1.34 - Connection string: ssh -J e2e-user@185.11.73.171 debian@10.12.4.139

🔴 e2e: DVP, Containerd, Kubernetes 1.34 failed in 38m0s.

@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🟢 e2e: Yandex.Cloud for deckhouse:fix/helm3lib-take-ownership succeeded in 43m35s.

Workflow details

Yandex.Cloud-WithoutNAT-Containerd-1.34 - Connection string: ssh cloud-user@158.160.41.35

🟢 e2e: Yandex.Cloud, Containerd, Kubernetes 1.34 succeeded in 42m16s.

@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🟢 e2e: DVP for deckhouse:fix/helm3lib-take-ownership succeeded in 35m27s.

Workflow details

DVP-WithoutNAT-Containerd-1.34 - Connection string: ssh -J e2e-user@185.11.73.171 debian@10.12.4.134

🟢 e2e: DVP, Containerd, Kubernetes 1.34 succeeded in 34m9s.

@ldmonster

ldmonster commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

/e2e/abort dvp;WithoutNAT;containerd;1.34 29572233068 29572233068-1-con-1-34 /sys/deckhouse-oss/install:pr21365 debian@10.12.4.139

@ldmonster

ldmonster commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

/e2e/abort dvp;WithoutNAT;containerd;1.34 29569259696 29569259696-1-con-1-34 /sys/deckhouse-oss/install:pr21365 debian@10.12.4.112

@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🟢 destroy cluster: DVP for refs/heads/main succeeded in 8m35s.

Workflow details

🟢 destroy cluster: DVP, Containerd, Kubernetes 1.34 succeeded in 7m58s.

@ldmonster

ldmonster commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

/e2e/abort dvp;WithoutNAT;containerd;1.34 29530280167 29530280167-1-con-1-34 /sys/deckhouse-oss/install:pr21365 debian@10.12.4.56

@ldmonster

ldmonster commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

/e2e/abort yandex-cloud;WithoutNAT;containerd;1.34 29530279630 29530279630-1-con-1-34 /sys/deckhouse-oss/install:pr21365 cloud-user@84.252.131.208

@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🟢 destroy cluster: DVP for refs/heads/main succeeded in 8m14s.

Workflow details

🟢 destroy cluster: DVP, Containerd, Kubernetes 1.34 succeeded in 7m50s.

@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🟢 destroy cluster: DVP for refs/heads/main succeeded in 6m0s.

Workflow details

🟢 destroy cluster: DVP, Containerd, Kubernetes 1.34 succeeded in 5m29s.

@ldmonster

ldmonster commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

/e2e/abort gcp;WithoutNAT;containerd;1.34 29418737812 29418737812-1-con-1-34 /sys/deckhouse-oss/install:pr21365

@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🟢 destroy cluster: Yandex.Cloud for refs/heads/main succeeded in 8m20s.

Workflow details

🟢 destroy cluster: Yandex.Cloud, Containerd, Kubernetes 1.34 succeeded in 8m0s.

@ldmonster

ldmonster commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

/e2e/abort gcp;WithoutNAT;containerd;1.34 29417755725 29417755725-1-con-1-34 /sys/deckhouse-oss/install:pr21365

@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🟢 destroy cluster: GCP for refs/heads/main succeeded in 1m50s.

Workflow details

🟢 destroy cluster: GCP, Containerd, Kubernetes 1.34 succeeded in 1m31s.

@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🟢 destroy cluster: GCP for refs/heads/main succeeded in 1m39s.

Workflow details

🟢 destroy cluster: GCP, Containerd, Kubernetes 1.34 succeeded in 1m23s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@090809 090809 090809 approved these changes
@ldmonster ldmonster ldmonster approved these changes
@miklezzzz miklezzzz miklezzzz approved these changes
@apolovov apolovov Awaiting requested review from apolovov apolovov is a code owner

Assignees

@Fkuloff Fkuloff

Labels

area/cluster-and-infrastructure Pull requests that update infra modules area/core Pull requests that update core modules area/network Pull requests that update cni and network modules security/gitleaks/success Gitleaks PR diff scan passed security/rootless/failed Default-user (rootless) validation failed type/dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

v1.76.5

Development

Successfully merging this pull request may close these issues.

5 participants

@Fkuloff @deckhouse-BOaTswain @ldmonster @090809 @miklezzzz