[module-sdk] warn not error on missing certificate secret#123
Merged
Conversation
diyliv
force-pushed
the
fix/copy-custom-certificate-warning-not-error
branch
3 times, most recently
from
July 20, 2026 14:31
dfb13dd to
036f17a
Compare
ldmonster
approved these changes
Jul 20, 2026
diyliv
force-pushed
the
fix/copy-custom-certificate-warning-not-error
branch
2 times, most recently
from
July 20, 2026 14:43
575fc23 to
562335d
Compare
Signed-off-by: diyliv <onlogn081@gmail.com>
diyliv
force-pushed
the
fix/copy-custom-certificate-warning-not-error
branch
from
July 20, 2026 14:44
562335d to
b1b286f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secretNamedoes not exist in the cluster, the hook now logs aWarnand sets placeholder values ("<none>") instead of returning a hard error.go_libimplementation this was a warning with fallback, but the module-sdk port incorrectly changed it toerrors.New()— causing infinite hook retries that block the parallel queue and prevent other modules from starting.common-hooks/copy-custom-certificate/hook.go,common-hooks/copy-custom-certificate/hook_internal_test.go.Context
When a user configures
https.mode: CustomCertificatewith asecretName, the secret might temporarily not exist (cert-manager not yet created, rotation in progress, etc.). The originalgo_libhook handled this gracefully — warn + fallback values + continue. The module-sdk version returned an error, which caused:failures 2316(endless retries)This fix aligns module-sdk behaviour with the original go_lib implementation.
Example
Before (broken):
→ queue status:
sleep after fail, other modules blocked.After (fixed):
→ queue status:
sleep, values set to<none>placeholders, other modules proceed normally.