Entrypoint tests - #393
Merged
Merged
Conversation
cherep58
reviewed
Jul 6, 2026
cherep58
approved these changes
Jul 8, 2026
…small Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # pp/BUILD # pp/entrypoint/Makefile # pp/entrypoint/bridge/go_constants.cpp
vporoshok
approved these changes
Jul 14, 2026
vporoshok
left a comment
vporoshok
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Рефакторинг корректный: split entrypoint на types/bridge + тесты. Собрано и протестировано локально в devcontainer (arm64, bazel 7.4.1): entrypoint_types/bridge/aio + entrypoint_types_test — PASSED. Сгенерированный go/cppbridge/entrypoint.h идентичен коммиченному. Ветка смержена с актуальным pp.
vporoshok
added a commit
that referenced
this pull request
Aug 6, 2026
* extract types from entrypoint * format fix * entrypoint tests * refine tests * entrypoint types tests build * move components to entrypoint * build fixes * consistent namespace naming * update namespaces in tests * rewiew fixes * review fixes: simplify type_headers path, mark entrypoint_types_test small Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Bastrykov Evgeniy <vporoshok@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit 7f07a28)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.