Optional arenas data storage - #464
Merged
Merged
Conversation
cherep58
marked this pull request as ready for review
August 5, 2026 13:22
vporoshok
approved these changes
Aug 6, 2026
vporoshok
pushed a commit
that referenced
this pull request
Aug 6, 2026
* added template paramter kUseArenas to DataStorage * added bool parameter for creating DataStorage with or without using arenas * removed entrypoint::types::SeriesDataEncoderWrapperPtr and created Encoder inplace in binding * fixed GC bug * fixed clang-tidy warnings * refactoring * compilation fix * fixed golang-ci (cherry picked from commit 8002fb3)
vporoshok
added a commit
that referenced
this pull request
Aug 7, 2026
Carries the v0.8.7 CHANGELOG section, VERSION, the govulncheck addition to Dockerfile.ci and the sanitize-html security bump. Everything under pp/, pp-pkg/ and cmd/ is kept exactly as it is on pp. The release branch holds backported variants of that code — the #464 arenas port adapted to the 0.8 API, and a scraper test rewritten against the older fixture — and merging those in would have downgraded the trunk. Two of them merged without a conflict and had to be caught by hand: scraper_tests.cpp ended up with make_scrape_buffer_past_4gib defined twice, and entrypoint/types/serialized_data.h reappeared although pp keeps that type in types/serialization.h. go.sum is likewise kept from pp: the tidy on release-0.8 was computed against an older go.mod (pp has newer pprof and genproto), so importing it would have left the trunk without hashes it needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.