chore: skip VirtualMachineLiveMigrationTCPSession test#1537
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR disables the unstable VirtualMachineLiveMigrationTCPSession e2e test by injecting a skip hook in its setup, pending resolution of a detected race condition. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `tests/e2e/vm_live_migration_tcp_session_test.go:68-71` </location>
<code_context>
storageClass = framework.GetConfig().StorageClass.TemplateStorageClass
)
+ BeforeAll(func() {
+ // TODO: The test is being disabled because running it with the ginkgo `--race` option detects a race condition.
+ // This leads to unstable test execution. Remove Skip after fixing the issue.
+ Skip("This test case is not working everytime. Should be fixed.")
+ })
+
</code_context>
<issue_to_address>
**suggestion (testing):** Test is being skipped due to instability, but no issue is referenced or tracked.
Please add a reference to a tracked issue or ticket for the race condition so the test can be properly re-enabled once resolved.
Suggested implementation:
```golang
// TODO: The test is being disabled because running it with the ginkgo `--race` option detects a race condition.
// This leads to unstable test execution. Remove Skip after fixing the issue.
// See: https://github.com/your-org/your-repo/issues/1234
Skip("This test case is not working everytime due to a race condition. See issue #1234.")
```
Replace `https://github.com/your-org/your-repo/issues/1234` and `issue #1234` with the actual issue or ticket reference that tracks the race condition for this test.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
LopatinDmitr
force-pushed
the
chore/skip-live-migr-tsp-session
branch
3 times, most recently
from
October 6, 2025 19:03
6bc6474 to
471a8cf
Compare
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
LopatinDmitr
force-pushed
the
chore/skip-live-migr-tsp-session
branch
from
October 6, 2025 19:17
471a8cf to
0c0edf0
Compare
eofff
approved these changes
Oct 6, 2025
yachmenevas
pushed a commit
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
Isteb4k
pushed a commit
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com> (cherry picked from commit db02619)
nevermarine
pushed a commit
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com> (cherry picked from commit db02619) Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Isteb4k
pushed a commit
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com> (cherry picked from commit db02619) Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
nevermarine
pushed a commit
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com> (cherry picked from commit db02619) Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
nevermarine
pushed a commit
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com> (cherry picked from commit db02619) Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
universal-itengineer
pushed a commit
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com> (cherry picked from commit db02619) Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
deckhouse-BOaTswain
pushed a commit
that referenced
this pull request
Jul 22, 2026
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com> (cherry picked from commit 48ff87a) Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
deckhouse-BOaTswain
pushed a commit
that referenced
this pull request
Jul 22, 2026
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com> (cherry picked from commit 48ff87a) Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Skip VirtualMachineLiveMigrationTCPSession test
Checklist