Skip to content

chore: skip VirtualMachineLiveMigrationTCPSession test#1537

Merged
LopatinDmitr merged 1 commit into
mainfrom
chore/skip-live-migr-tsp-session
Oct 6, 2025
Merged

chore: skip VirtualMachineLiveMigrationTCPSession test#1537
LopatinDmitr merged 1 commit into
mainfrom
chore/skip-live-migr-tsp-session

Conversation

@LopatinDmitr

@LopatinDmitr LopatinDmitr commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

Description

Skip VirtualMachineLiveMigrationTCPSession test

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@LopatinDmitr LopatinDmitr added this to the v1.2.0 milestone Oct 6, 2025
@LopatinDmitr LopatinDmitr self-assigned this Oct 6, 2025
@sourcery-ai

sourcery-ai Bot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR disables the unstable VirtualMachineLiveMigrationTCPSession e2e test by injecting a skip hook in its setup, pending resolution of a detected race condition.

File-Level Changes

Change Details Files
Skip unstable VirtualMachineLiveMigrationTCPSession test until race condition is fixed
  • Added a BeforeAll hook invoking Skip() to bypass test execution
  • Included a TODO comment outlining the need to remove the skip once the race issue is resolved
tests/e2e/vm_live_migration_tcp_session_test.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@LopatinDmitr
LopatinDmitr requested a review from eofff October 6, 2025 17:27

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `tests/e2e/vm_live_migration_tcp_session_test.go:68-71` </location>
<code_context>
 		storageClass = framework.GetConfig().StorageClass.TemplateStorageClass
 	)

+	BeforeAll(func() {
+		// TODO: The test is being disabled because running it with the ginkgo `--race` option detects a race condition.
+		// This leads to unstable test execution. Remove Skip after fixing the issue.
+		Skip("This test case is not working everytime. Should be fixed.")
+	})
+
</code_context>

<issue_to_address>
**suggestion (testing):** Test is being skipped due to instability, but no issue is referenced or tracked.

Please add a reference to a tracked issue or ticket for the race condition so the test can be properly re-enabled once resolved.

Suggested implementation:

```golang
		// TODO: The test is being disabled because running it with the ginkgo `--race` option detects a race condition.
		// This leads to unstable test execution. Remove Skip after fixing the issue.
		// See: https://github.com/your-org/your-repo/issues/1234
		Skip("This test case is not working everytime due to a race condition. See issue #1234.")

```

Replace `https://github.com/your-org/your-repo/issues/1234` and `issue #1234` with the actual issue or ticket reference that tracks the race condition for this test.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread tests/e2e/vm_live_migration_tcp_session_test.go Outdated
@LopatinDmitr
LopatinDmitr force-pushed the chore/skip-live-migr-tsp-session branch 3 times, most recently from 6bc6474 to 471a8cf Compare October 6, 2025 19:03
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr
LopatinDmitr force-pushed the chore/skip-live-migr-tsp-session branch from 471a8cf to 0c0edf0 Compare October 6, 2025 19:17
@LopatinDmitr
LopatinDmitr merged commit db02619 into main Oct 6, 2025
29 of 30 checks passed
@LopatinDmitr
LopatinDmitr deleted the chore/skip-live-migr-tsp-session branch October 6, 2025 19:29
@Isteb4k Isteb4k modified the milestones: v1.2.0, v1.1.1 Oct 14, 2025
yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
Isteb4k pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
(cherry picked from commit db02619)
nevermarine pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
(cherry picked from commit db02619)
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Isteb4k pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
(cherry picked from commit db02619)
Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
nevermarine pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
(cherry picked from commit db02619)
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
nevermarine pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
(cherry picked from commit db02619)
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
universal-itengineer pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
(cherry picked from commit db02619)
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
deckhouse-BOaTswain pushed a commit that referenced this pull request Jul 22, 2026
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
(cherry picked from commit 48ff87a)
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
deckhouse-BOaTswain pushed a commit that referenced this pull request Jul 22, 2026
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
(cherry picked from commit 48ff87a)
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants