Skip to content

chore: skip for VirtualImageCreation blinking test#1539

Merged
eofff merged 1 commit into
mainfrom
fix/test/skip-vi-test
Oct 6, 2025
Merged

chore: skip for VirtualImageCreation blinking test#1539
eofff merged 1 commit into
mainfrom
fix/test/skip-vi-test

Conversation

@eofff

@eofff eofff commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

Description

Skip for VirtualImageCreation blinking test.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@sourcery-ai

sourcery-ai Bot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enhance VirtualImageCreation e2e test to capture intermittent failures during phase waits and automatically skip subsequent test steps to mitigate flakiness.

File-Level Changes

Change Details Files
Introduce error tracking and skip logic for test flakiness
  • Declare a criticalError variable to hold intercepted failures
  • Add BeforeEach hook to skip tests when criticalError is set
tests/e2e/images_creation_test.go
Wrap WaitPhaseByLabel call with failure interception
  • Replace direct WaitPhaseByLabel invocation with InterceptGomegaFailure wrapper
  • Assign any captured error to criticalError for later skip logic
tests/e2e/images_creation_test.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@eofff eofff added this to the v1.2.0 milestone Oct 6, 2025

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@eofff
eofff merged commit 554d2ee into main Oct 6, 2025
34 of 36 checks passed
@eofff
eofff deleted the fix/test/skip-vi-test branch October 6, 2025 20:16
@Isteb4k Isteb4k modified the milestones: v1.2.0, v1.1.1 Oct 14, 2025
yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Isteb4k pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
(cherry picked from commit 554d2ee)
nevermarine pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
(cherry picked from commit 554d2ee)
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Isteb4k pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
(cherry picked from commit 554d2ee)
Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
nevermarine pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
(cherry picked from commit 554d2ee)
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
nevermarine pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
(cherry picked from commit 554d2ee)
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
universal-itengineer pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
(cherry picked from commit 554d2ee)
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
deckhouse-BOaTswain pushed a commit that referenced this pull request Jul 22, 2026
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
(cherry picked from commit df993a3)
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
deckhouse-BOaTswain pushed a commit that referenced this pull request Jul 22, 2026
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
(cherry picked from commit df993a3)
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants