chore: skip vd snapshots blinking error

[eofff]

Description

Skip VDSnapshot blinking error.

Checklist

• The code is covered by unit tests.
• e2e tests passed.
• Documentation updated according to the changes.
• Changes were tested in the Kubernetes cluster manually.

[sourcery-ai]

Reviewer's Guide

This PR modifies the VirtualDiskSnapshots e2e test to suppress intermittent “blinking” failures by capturing the readiness assertion into a shared error variable and skipping subsequent test execution when such a failure occurs.

File-Level Changes

Change	Details	Files
Introduce a shared error variable and skip guard for blinking errors	Declare a criticalErr error at the top of the test suite Add a BeforeAll check to Skip the suite if criticalErr is non-nil	tests/e2e/vd_snapshots_test.go
Capture intermittent snapshot readiness failures via InterceptGomegaFailure	Wrap the Eventually(...) assertion inside InterceptGomegaFailure Assign the returned error to criticalErr instead of letting the test fail immediately	tests/e2e/vd_snapshots_test.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Rather than tracking a global criticalErr to skip all subsequent specs, consider using Ginkgo’s built-in retry/flake support (e.g. FlakeAttempts) or per-spec skips to handle intermittent snapshot failures without hiding other tests.
• When you intercept the Gomega failure, make sure to log or surface the original error message so debugging the root cause of the snapshot flake is easier before it gets skipped.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Rather than tracking a global `criticalErr` to skip all subsequent specs, consider using Ginkgo’s built-in retry/flake support (e.g. `FlakeAttempts`) or per-spec skips to handle intermittent snapshot failures without hiding other tests.
- When you intercept the Gomega failure, make sure to log or surface the original error message so debugging the root cause of the snapshot flake is easier before it gets skipped.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}