feat(vmclass): use percentage format for coreFractions values #1601
+3,416
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loktev-d
requested review from
Isteb4k,
danilrwx,
fl64,
goganat,
hardcoretime,
yaroslavborbat and
z9r5
as code owners
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Sorry @loktev-d, your pull request is larger than the review limit of 150000 diff characters
Signed-off-by: Daniil Loktev <70405899+loktev-d@users.noreply.github.com>
z9r5
reviewed
Oct 21, 2025
z9r5
previously approved these changes
Oct 22, 2025
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
Co-authored-by: Artem Kladov <6360800+z9r5@users.noreply.github.com> Signed-off-by: Daniil Loktev <70405899+loktev-d@users.noreply.github.com> Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
This reverts commit ca8b840. Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
loktev-d
force-pushed
the
feat/vmclass/core-fractions-percentage
branch
from
ffe3f98 to
5458ff6
Compare
Isteb4k
requested review from
nevermarine and
universal-itengineer
as code owners
Isteb4k
requested changes
Nov 10, 2025
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
…ctions-percentage
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
Isteb4k
approved these changes
Nov 19, 2025
Merged
4 tasks
nevermarine
pushed a commit
that referenced
this pull request
Nov 19, 2025
Introduce v1alpha3 version of VirtualMachineClass with percentage string format (e.g., 5 → "5%") for coreFractions. Use Kubernetes conversion webhooks for version compatibility between v1alpha2 and v1alpha3 - v1alpha2: Maintains original coreFractions: []int format for backward compatibility - v1alpha3 (storage version): Introduces new coreFractions: []string format with "%" suffix - Conversion webhook: Provides automatic bidirectional conversion between versions (v1alpha2 is hub, v1alpha3 is spoke). Injected into VirtualMachineClass CRD on controller startup. - Admission webhook: Added conversion to hub version so that validation is compatible with both versions E2E tests: use new v1alpha3 version Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com> Co-authored-by: Artem Kladov <6360800+z9r5@users.noreply.github.com> Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce
v1alpha3version ofVirtualMachineClasswith percentage string format (e.g., 5 → "5%") forcoreFractions. Use Kubernetes conversion webhooks for version compatibility betweenv1alpha2andv1alpha3Key changes
v1alpha2is hub,v1alpha3is spoke). Injected into VirtualMachineClass CRD on controller startup.Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries