Skip to content

Conversation

@diafour
Copy link
Member

@diafour diafour commented Nov 19, 2025

Description

  • Change vmclass generic manifest to use strings for coreFractions.
  • Fix error when hook trying to patch vmclass/generic without annotations.

Why do we need it, and what problem does it solve?

  1. Upgrade vmclass version after merging feat(vmclass): use percentage format for coreFractions values #1601.
  2. Fix blocking the main queue when new vmclass generic is created, but module-state secret is not created. E.g. this error may occur during the first installation of the module when ModuleConfig is invalid.

What is the expected result?

Newly created vmclass/generic has "apiVersion: virtualization.deckhouse.io/v1alpha3".

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: module
type: chore
summary: Upgrade version to v1alpha3 for vmclass/generic, fix blocking main queue in case of unsuccessful module installation.

- Change vmclass generic manifest to use strings for coreFractions.
- Fix error when hook trying to patch vmclass/generic without annotations.

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour diafour added this to the v1.2.0 milestone Nov 19, 2025
@LopatinDmitr LopatinDmitr self-requested a review November 19, 2025 15:45
@diafour diafour marked this pull request as draft November 20, 2025 09:18
@Isteb4k Isteb4k modified the milestones: v1.2.0, v1.3.0 Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants