fix(vm): cleanup cpu.features on KVVM after vmclass change

[diafour]

Description

• reset cpu.features when generate KVVM

Why do we need it, and what problem does it solve?

The problem occurs when VM started with Discovery type vmclass and then vmclass is changed to a non-Discovery type. - cpu.features are kept and they are passed to a nodeSelector for VM Pod. User may encounter unexpected Pod scheduling problems after vmclass change.

What is the expected result?

No cpu.features in KVVM when change Discovery vmclass to a non-Discovery vmclass, e.g. Model.

VM classes:

vmclass/generic

  spec:
    cpu:
      model: Nehalem
      type: Model

vmclass/discovery

    cpu:
      discovery:
        nodeSelector: {}
      type: Discovery

VM state

$ kubectl get vm testvm -o jsonpath='{.spec.virtualMachineClassName}'
discovery

$ kubectl get intvirtvm testvm -o jsonpath='{"Model: "}{.spec.template.spec.domain.cpu.model}{"\n"}{"Features: "}{.spec.template.spec.domain.cpu.features }'

Model: qemu64
Features: [{"name":"aes","policy":"require"},....,{"name":"svm","policy":"optional"}]

$ kubectl patch vm testvm --type merge -p '{"spec":{"virtualMachineClassName":"generic"}}'

Before:

$ kubectl get intvirtvm testvm -o jsonpath='{"Model: "}{.spec.template.spec.domain.cpu.model}{"\n"}{"Features: "}{.spec.template.spec.domain.cpu.features }'

Model: Nehalem
Features: [{"name":"aes","policy":"require"},....,{"name":"svm","policy":"optional"}]

After:

$ kubectl get intvirtvm testvm -o jsonpath='{"Model: "}{.spec.template.spec.domain.cpu.model}{"\n"}{"Features: "}{.spec.template.spec.domain.cpu.features }'

Model: Nehalem
Features: 

Checklist

• The code is covered by unit tests.
• e2e tests passed.
• Documentation updated according to the changes.
• Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: fix
summary: Fix possible scheduling problems after changing vmclass from Discovery type to Model type.