Skip to content

fix(vm): cleanup cpu.features on KVVM after vmclass change #2352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diafour merged 3 commits into from
May 19, 2026
Merged

fix(vm): cleanup cpu.features on KVVM after vmclass change #2352

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a192d2
fix(vm): cleanup cpu.features on KVVM after vmclass change
diafour May 15, 2026
b31e5d7
++ try with features=nil
diafour May 18, 2026
d3afcab
++ try with features=nil
diafour May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions images/virtualization-artifact/pkg/controller/kvbuilder/kvvm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,8 @@ func (b *KVVM) SetCPUModel(class *v1alpha2.VirtualMachineClass) error {
b.Resource.Spec.Template.Spec.Domain.CPU = &virtv1.CPU{}
}
cpu := b.Resource.Spec.Template.Spec.Domain.CPU
// Reset features to handle vmclass changes: only discovery type sets features.
cpu.Features = nil

switch class.Spec.CPU.Type {
case v1alpha2.CPUTypeHost:
Expand Down
Loading