fix(pvc-artifact): relicense CDI-derived files with recognized header#2628
Closed
Isteb4k wants to merge 1 commit into
Closed
fix(pvc-artifact): relicense CDI-derived files with recognized header#2628Isteb4k wants to merge 1 commit into
Isteb4k wants to merge 1 commit into
Conversation
The DMT license linter rejects the CDI copyright headers on the code
vendored into pvc-artifact ("license header does not match any known
license"). Replace them with the standard Flant JSC Apache 2.0 header
recognized by the linter and add a note crediting the Containerized Data
Importer (CDI) project as the origin, matching the convention already used
in images/dvcr-artifact.
Signed-off-by: Dmitry Rakitin <dmitry.rakitin@flant.com>
Isteb4k
force-pushed
the
fix/pvc-artifact-license-and-pvc-protection-finalizer
branch
from
7047b99 to
b93e671
Compare
Isteb4k
changed the title
Isteb4k
force-pushed
the
fix/pvc-artifact-license-and-pvc-protection-finalizer
branch
from
b93e671 to
d777813
Compare
Isteb4k
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The 22 CDI-derived Go files under
images/pvc-artifactstill carry theCopyright <year> The CDI Authors.header. This replaces them with the standardFlant JSC Apache 2.0 header, followed by a note crediting the Containerized Data
Importer (CDI) project as the origin — the same convention already used in
images/dvcr-artifact.Why do we need it, and what problem does it solve?
The DMT
licenselinter rejects the CDI headers with "license header does notmatch any known license", which fails the DMT check on every PR touching
pvc-artifact. The Flant JSC header is recognized by the linter, and the CDIattribution note preserves the origin of the vendored code.
What is the expected result?
The DMT
licensecheck passes onimages/pvc-artifact; nopvc-artifactfilereports "license header does not match any known license".
Checklist
Changelog entries