chore: add code quality tooling (Biome + Knip) and apply formatting - #2
Merged
Conversation
- Add Biome 2.4.6 for linting and formatting - Add Knip for dead code detection - Add scripts: lint, lint:fix, lint:unused, format, format:fix, check - Configure biome.json with recommended rules (noExplicitAny off, noDangerouslySetInnerHtml off for framework needs) - Configure knip.json to detect unused exports Made-with: Cursor
- Auto-format all source files with Biome (import ordering, consistent spacing, trailing commas) - Fix duplicate else-if condition in generate-schema.ts (line 185: nullable string branch was unreachable because the non-nullable string branch above already matched) All checks pass: tsc --noEmit, biome check, knip Made-with: Cursor
There was a problem hiding this comment.
1 issue found across 40 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/sdk/instrumentedFetch.ts">
<violation number="1" location="src/sdk/instrumentedFetch.ts:122">
P1: `instrumentFetch` ignores the `originalFetch` argument and always uses `globalThis.fetch`, so custom client fetch behavior is bypassed.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
🎉 This PR is included in version 0.16.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
noDangerouslySetInnerHtmloff for LiveControls/inline scripts,noExplicitAnyoff for generic utilities)lint,lint:fix,lint:unused,format,format:fix,check(runs all quality checks)else ifbranch ingenerate-schema.ts— the nullable string condition on line 185 was unreachable because the non-nullable string branch above already matched the same caseAll checks pass:
Test plan
npm run checkpasses (typecheck + lint + knip)npm run buildsucceedsMade with Cursor
Summary by cubic
Add
@biomejs/biomeandknipto standardize code quality and catch dead code, then apply project-wide formatting. Also fixes an unreachable branch in the schema generator.Dependencies
@biomejs/biome2.4.6 for linting/formatting with recommended rules (disablenoDangerouslySetInnerHtml,noExplicitAny,noNonNullAssertion).knipfor detecting unused files/exports/dependencies.Bug Fixes
scripts/generate-schema.ts(nullable string branch was shadowed).Written for commit 624cca1. Summary will update on new commits.