fix(fast-deploy): errcheck res.Body.Close in cfkv#30
Merged
Conversation
golangci-lint errcheck flagged the deferred res.Body.Close() in the index:live REST GET. Discard the return explicitly. No behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lint(errcheck) went red onmainafter #29 merged:internal/deploy/cfkv.go:35deferredres.Body.Close()without discarding the error. Wrap it (defer func() { _ = res.Body.Close() }()). Lint-only — no behavior change, and thev0.10.0release image/chart are unaffected (that workflow doesn't run golangci-lint).🤖 Generated with Claude Code
Summary by cubic
Fixes
golangci-linterrcheck by wrappingres.Body.Close()ininternal/deploy/cfkv.goto explicitly discard the error. No behavior change; restores green CI for fast-deploy.Written for commit 228498f. Summary will update on new commits.