Skip to content

fix(orchestrator): correct the deploy guidance — CF Workers Builds, no deco Admin flow - #333

Merged
JonasJesus42 merged 1 commit into
mainfrom
plugin-deco-app-setup-guide
Sep 2, 2026
Merged

fix(orchestrator): correct the deploy guidance — CF Workers Builds, no deco Admin flow#333
JonasJesus42 merged 1 commit into
mainfrom
plugin-deco-app-setup-guide

Conversation

@JonasJesus42

@JonasJesus42 JonasJesus42 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #332, which I got wrong.

What #332 got wrong

It added a Step 1 telling the user to go to admin.deco.cx → Sites → New Site. That flow does not exist — I inferred it from the symptom instead of checking, and it would have sent every non-dev user hunting for a page that isn't there.

It also described account_id / DECO_KV / SITES_KV / deco-otel-tail as "placeholders that become valid after registration". They aren't placeholders. deco-sites/storefront-tanstack's wrangler.jsonc ships real resources in deco's CF account:

"name": "storefront-tanstack",
"account_id": "c95fc4cec7fc52453228d9db170c372c",
"tail_consumers": [{ "service": "deco-otel-tail" }],
"kv_namespaces": [ { "binding": "DECO_KV", "id": "a205a78e..." }, ... ]

That distinction matters: a local wrangler deploy fails because the CLI isn't in that account, and deleting the keys until it succeeds is exactly what publishes the client's site onto whatever account the local token happens to own.

What this PR does

  • Deploy setup is one manual step: CF dash → Workers & Pages → Create application → Connect to Git → pick the repo. The orchestrator asks for it up front instead of discovering it's missing after a 3-minute wait, and the prompt tells the user to check the account switcher.
  • Keeps and re-grounds the ⛔ guard on wrangler deploy — now with the real reason.
  • New Step 1 — rename the worker. template-bootstrap says "copy the tree, re-init git" and never touches name / DECO_SITE_NAME, so every migrated site currently deploys claiming to be storefront-tanstack. Found while verifying the above; shout if you'd rather split it out.

🤖 Generated with Claude Code


Summary by cubic

Fixes the migration orchestrator's deploy instructions so users set up Cloudflare Workers Builds directly, instead of following a nonexistent deco Admin site flow.

  • Removes the admin.deco.cx → Sites → New Site step; connecting the repo in the Cloudflare dashboard is now the one manual setup step.
  • Adds a required first step to rename the worker from storefront-tanstack to the site slug in wrangler.jsonc.
  • Clarifies that account_id, DECO_KV, SITES_KV, and deco-otel-tail are real resources in deco's Cloudflare account, and deleting them to force a local wrangler deploy can publish the site to whatever account the local token owns.

Written for commit 09ad339. Summary will update on new commits.

Review in cubic

…o deco Admin flow

#332 invented an "admin.deco.cx -> Sites -> New Site" step that does not exist.
The real setup is one manual step: create a Workers & Pages app in the CF dash
pointed at the repo.

Also grounds the wrangler.jsonc guard in what the template actually ships: real
deco-account resources (account_id, DECO_KV/SITES_KV ids, deco-otel-tail), not
placeholders — which is why stripping them to force a local deploy publishes to
whatever account the local token owns.

Adds the missing rename step: the copied template keeps name/DECO_SITE_NAME as
"storefront-tanstack" and template-bootstrap never changed them.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant