Skip to content

fix(registry): add aria-label to icon-only actions menu triggers#4903

Merged
pedrofrxncx merged 1 commit into
mainfrom
fix/registry-item-actions-menu-aria-label-w2
Jul 20, 2026
Merged

fix(registry): add aria-label to icon-only actions menu triggers#4903
pedrofrxncx merged 1 commit into
mainfrom
fix/registry-item-actions-menu-aria-label-w2

Conversation

@pedrofrxncx

@pedrofrxncx pedrofrxncx commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Source: debt cleanup in the registry UI area (accessibility gap, no linked issue).

Why: the per-item "⋮" DropdownMenuTrigger Button in registry-item-card.tsx (grid view) and registry-items-page.tsx (table view) has no visible text and no aria-label — a screen reader announces it with no name, so a keyboard/AT user in the registry catalog can't tell what the button does before opening it. The rest of the codebase already has an established fix for this exact shape (aria-label={\Actions for ${name}`}on icon-onlyDropdownMenuTriggerbuttons — seeapps/mesh/src/web/layouts/library/cards.tsxandapps/mesh/src/web/components/file-picker/file-picker-dialog.tsx`); this PR brings the two registry views in line with that convention.

Change: added aria-label={\Actions for ${item.title}`}` to the two icon-only dots-menu triggers. No behavior change, no visual change — purely an accessible-name fix. +2/-0 lines of real change (plus reflow from Biome).

How to verify: open the registry catalog (grid and table view) and inspect the "⋮" button in the accessibility tree / with a screen reader — it now announces "Actions for <item title>" instead of nothing.

Checks run locally: bun run fmt (clean) and cd apps/mesh && bunx tsc --noEmit (clean, no type errors). No test file covers this (pure JSX attribute addition, not logic) — full CI runs the rest.


Summary by cubic

Added aria-labels to the icon-only "⋮" actions buttons in the registry card and table so screen readers announce "Actions for ". No visual or behavior changes; aligns with the existing "Actions for ${name}" pattern used elsewhere.

Written for commit dc16e23. Summary will update on new commits.

Review in cubic

The dots-menu Button that opens the per-item DropdownMenu (edit/delete/etc) in
the registry catalog card and table row has no text content and no
aria-label, so screen readers announce it with no name. Other icon-only
DropdownMenuTrigger buttons in the codebase (e.g. library cards,
file-picker-dialog) already follow the `Actions for ${name}` pattern; this
brings the two registry views in line with it.
@pedrofrxncx
pedrofrxncx enabled auto-merge (squash) July 20, 2026 23:42
@pedrofrxncx
pedrofrxncx merged commit 058fd07 into main Jul 20, 2026
15 of 16 checks passed
@pedrofrxncx
pedrofrxncx deleted the fix/registry-item-actions-menu-aria-label-w2 branch July 20, 2026 23:48
decocms Bot pushed a commit that referenced this pull request Jul 20, 2026
PR: #4903 fix(registry): add aria-label to icon-only actions menu triggers
Bump type: patch

- decocms (apps/mesh/package.json): 4.82.6 -> 4.82.7

Deploy-Scope: web
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant