fix(cms-tour): only anchor the submit step on the create-PR state - #5133
Merged
Conversation
The tour's "submit for review" step anchored `tour-submit` on the header's primary action button unconditionally. In neutral states — notably "Up to date" (disabled, no action) — the step highlighted an unrelated button whose label contradicted the step copy. Gate the anchor on `button.action === "create-pr"` so the step only shows when submitting is the actual next action; otherwise it's skipped via driver.js `skipMissingElement`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
decocms Bot
pushed a commit
that referenced
this pull request
Jul 23, 2026
PR: #5133 fix(cms-tour): only anchor the submit step on the create-PR state Bump type: patch - decocms (apps/mesh/package.json): 4.113.0 -> 4.113.1 Deploy-Scope: web
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fix for the CMS visual tour (shipped in #5055).
The "submit for review" step anchored
tour-submiton the header's primary action button unconditionally. In neutral states — notably "Up to date" (disabled, noaction) — the step highlighted that button, so the spotlight landed on a control whose label ("Atualizado") contradicts the step copy ("Enviar para revisão").Fix
Gate the anchor on the button actually being in the submit state:
When the branch is up-to-date (or in any non-submit state), the anchor is absent and driver.js skips the step via
skipMissingElement.tour-publishwas already state-gated (green Publish side button / merge-split only render when there's something to publish), so no change needed there.Testing
bunx tsc— 0 errorsbun run lint— cleancreate-pris the submit-for-review action inpanel-state.ts.🤖 Generated with Claude Code
Summary by cubic
Fixes the CMS visual tour so the “Submit for review” step only shows when the primary action is actually submit (create PR). Prevents highlighting the disabled “Up to date” button.
data-touronly whenbutton.action === "create-pr"; otherwise omit the anchor so the tour skips the step.Written for commit bedbc9c. Summary will update on new commits.