feat(pty): add Unix PTY spawn and I/O - #36
Merged
Conversation
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #35
status:approvedlabel.Pull request type
Select exactly one option and apply the matching
type:*label.type:bug)type:feature)type:docs)type:refactor)type:chore)type:breaking-change)Summary
portable-ptybackend for structured spawn, shell startup, buffered UTF-8 output, input, process identity, and basic liveness.ca1475ad489814327255cb4148584369825ad524from lineagereview-bccf9b5e0bf02b61.Changes
crates/splice-pty/src/lib.rscrates/splice-pty/tests/unix_pty.rscrates/splice-pty/Cargo.tomlCargo.lockReview budget
373 additions + 27 deletions), excluding generatedCargo.lock.Cargo.lock(102 additions + 2 deletions).Test plan
cargo fmt --all -- --checkpassed;cargo test -p splice-ptypassed 25/25 native tests;cargo clippy -p splice-pty --all-targets -- -D warningspassed.Chained pull request context
Strategy: stacked-to-main, PR3 of 15. Each slice targets
masterafter its dependencies merge.masterat23af77a.Rollback
Revert commit
f0a2baf6f59c67d04e124d84cb437d438b32878cto remove the Unix backend, its tests, and its dependency/lock changes without affecting merged PR1-2 behavior.Contributor checklist
Closes,Fixes, orResolves.type:*label.Co-Authored-Bytrailers.