fix(web): page-theme 테스트 params mock에 locale 추가 (tsc)#890
Merged
Conversation
`[locale]/(shell)/profile/[userId]` 라우트의 params 타입은 `{ userId, locale }`
인데 #839 page-theme 테스트가 `{ userId }`만 mock 하여 tsc 타입 불일치(TS2322)
가 발생했다. 로컬 tsc / next build 에서만 드러나던 것(web typecheck CI 부재).
mock 에 `locale: "en"` 추가로 해소. 런타임 동작·단언 불변.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2 tasks
cocoyoon
added a commit
that referenced
this pull request
Jul 12, 2026
- LikesGrid: 좋아요 포스트 카드에서 post_title 화면 노출 제거(alt 텍스트로만 유지) — Saved Looks 와 동일 규칙(#890 회귀 방지). 오버레이는 좋아요 시각만. - SavedLookSetsGrid: 하드코딩 문자열 전부 next-intl 로 전환(Library 네임스페이스). 빈 상태 카피의 어색한 "Recreate this style 카드에서~보세요"를 자연스러운 서비스 톤으로 교체("룩 상세에서 마음에 드는 조합을 저장하면 여기에 모여요" / "Save the combinations you love from any look…"). error·retry· itemCount(ICU plural)·removeAria·removeError·cardAlt 도 함께 localize. - messages/{ko,en}.json: Library.lookSets 에 신규 키(ko 는 실제 한국어). 검증: typecheck·prettier·유닛 819 통과. 브라우저(로그인) Library Likes 탭 타이틀 미노출 + Look Sets 빈 상태 신규 카피 확인. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
#839
page-theme.test.tsx의 params mock에locale필드를 추가한다.Why
[locale]/(shell)/profile/[userId]라우트의 params 타입은{ userId, locale }인데 테스트가{ userId }만 mock 하여tsc타입 불일치(TS2322)가 발생. web typecheck CI가 없어 CI엔 안 잡혔으나 로컬tsc --noEmit/next build에서 드러난다. (#860 머지 후 노출.)Changes
{ userId: "u1", locale: "en" }로 보정.Verify
tsc --noEmit0 (전체 web) · page-theme 테스트 1/1 pass · 런타임 단언 불변🤖 Generated with Claude Code