secp256k1: Support go generate w/o removing file.#2884
Merged
davecgh merged 1 commit intodecred:masterfrom Mar 2, 2022
Merged
Conversation
This modifies the logic that deals with generating, loading, and decompressing the compressed byte points to allow go generate to run correctly regardless of whether or not the generated file already exists. It accomplishes this by making use of a function to obtain the compressed byte points string instead of directly referencing the variable such that the function is nil by default and only set to the real function via the generated file.
davecgh
force-pushed
the
secp256k1_clean_generate
branch
from
8f4537c to
64b67b0
Compare
dajohi
approved these changes
Feb 23, 2022
dnldd
approved these changes
Feb 24, 2022
matheusd
approved these changes
Feb 28, 2022
Member
matheusd
left a comment
matheusd
left a comment
There was a problem hiding this comment.
Tested both with and without the compressedbytepoints.go file present.
JoeGruffins
approved these changes
Mar 1, 2022
rstaudt2
approved these changes
Mar 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the logic that deals with generating, loading, and decompressing the compressed byte points to allow go generate to run correctly regardless of whether or not the generated file already exists.
It accomplishes this by making use of a function to obtain the compressed byte points string instead of directly referencing the
variable such that the function is nil by default and only set to the real function via the generated file.