secp256k1: Decouple precomputation generation.#2886
Merged
davecgh merged 1 commit intodecred:masterfrom Mar 3, 2022
Merged
Conversation
dnldd
approved these changes
Feb 24, 2022
matheusd
approved these changes
Feb 28, 2022
Member
matheusd
left a comment
matheusd
left a comment
There was a problem hiding this comment.
Verified generation is unchanged.
rstaudt2
approved these changes
Mar 2, 2022
Member
rstaudt2
left a comment
rstaudt2
left a comment
There was a problem hiding this comment.
Looks good, confirmed that the generation is unchanged. I noticed that the copyright year in dcrec/secp256k1/curve.go could be updated as well.
davecgh
force-pushed
the
secp256k1_decouple_genprecomps
branch
from
cfab97f to
fafc851
Compare
Member
Author
Good call. Updated copyright year. |
The current code that generates the various pre-computed values is conditionally exported via a build tag that is only set when the code generation is invoked. That approach was originally necessary because it relied on access to unexported code to perform the calculations, however, now that the package has evolved, the exported API now provides all of the necessary tools. Consequently, this decouples the code related to generating pre-computed values as follows: - Move the code into the main package that is invoked by go generate - Updates the generation code to decouple it from the package internals - Removes the no longer necessary genstatics.go file - Removes the gensecp256k1 build tag that is no longer necessary
davecgh
force-pushed
the
secp256k1_decouple_genprecomps
branch
from
fafc851 to
18e28d3
Compare
JoeGruffins
approved these changes
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires #2884 and is rebased on #2885.
The current code that generates the various pre-computed values is conditionally exported via a build tag that is only set when the code generation is invoked. That approach was originally necessary because it relied on access to unexported code to perform the calculations, however, now that the package has evolved, the exported API now provides all of the necessary tools.
Consequently, this decouples the code related to generating pre-computed values as follows:
mainpackage that is invoked bygo generategenstatics.gofilegensecp256k1build tag that is no longer necessary